Upgrade simplesamlphp to version 1.14.15

Bug #1712711 reported by Robert Lyon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
High
Cecilia Vela Gurovic
16.10
Fix Released
High
Unassigned
17.04
Fix Released
High
Cecilia Vela Gurovic
17.10
Fix Released
High
Cecilia Vela Gurovic

Bug Description

Currently we are on 1.14.7 but as per https://simplesamlphp.org/ there are some security releases out.

So we should upgrade our version

Robert Lyon (robertl-9)
Changed in mahara:
milestone: none → 17.10.0
Revision history for this message
Robert Lyon (robertl-9) wrote :

I'm guessing it's a matter of updating the Makefile to point to the newer version of the simplesamlphp file and have some admin warning that 'your current version is out of date and you need to run "make cleanssphp && make ssphp"'

Revision history for this message
Robert Lyon (robertl-9) wrote :

It looks like simplesamlphp uses $config->getVersion(); to get the current version

So we'd need to compare that to a value set in mahara for version which we could set into auth_config with value plugin=saml, field=version, value=1.14.15

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/7951

Revision history for this message
Cecilia Vela Gurovic (ceciliavg) wrote :

Steps for testing:

Checkout master (or release branch to test)
in Mahara directory run "make cleanssphp && make ssphp"
Checkout patch

Go to Extension -> Plugin administration
search for Saml plugin and click on "setting"
There should not be any messages displayed warning to upgrade the saml plugin

Go to Admin Home
There should be a new saml plugin to install
click on Install via extensions page

Go to Extension - Plugin administration again
search for Saml plugin and click on "setting"
Now there is a message warning to upgrade the version on saml library

Run "make cleanssphp && make ssphp" in Mahara directory
Go again to saml plugin settings
the warning message should not be displayed anymore

Run "make cleanssphp" in Mahara directory
Go again to saml plugin settings
there should not be a message to upgrade saml,
but there should be a message to install saml instead

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/7951
Committed: https://git.mahara.org/mahara/mahara/commit/9c2c3b3ea07b4cc93f8737001a749decaa86fd13
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 9c2c3b3ea07b4cc93f8737001a749decaa86fd13
Author: Cecilia Vela Gurovic <email address hidden>
Date: Mon Aug 28 15:08:34 2017 +1200

Bug 1712711: Adding checks to ask for 1.14.16 saml lib upgrade

behatnotneeded

Change-Id: If1e267fb551faff3be2537b14a6b8917b263dddd

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "17.04_STABLE" branch: https://reviews.mahara.org/8049

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "16.10_STABLE" branch: https://reviews.mahara.org/8050

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/8049
Committed: https://git.mahara.org/mahara/mahara/commit/18ae2678460447ba2eade9b8f0baa9beef6427a6
Submitter: Robert Lyon (<email address hidden>)
Branch: 17.04_STABLE

commit 18ae2678460447ba2eade9b8f0baa9beef6427a6
Author: Cecilia Vela Gurovic <email address hidden>
Date: Mon Aug 28 15:08:34 2017 +1200

Bug 1712711: Adding checks to ask for 1.14.16 saml lib upgrade

behatnotneeded

Change-Id: If1e267fb551faff3be2537b14a6b8917b263dddd

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/8050
Committed: https://git.mahara.org/mahara/mahara/commit/668b26db033377a0003c1b09f3b5a565a9e0b6f4
Submitter: Robert Lyon (<email address hidden>)
Branch: 16.10_STABLE

commit 668b26db033377a0003c1b09f3b5a565a9e0b6f4
Author: Cecilia Vela Gurovic <email address hidden>
Date: Mon Aug 28 15:08:34 2017 +1200

Bug 1712711: Adding checks to ask for 1.14.16 saml lib upgrade

behatnotneeded

Change-Id: If1e267fb551faff3be2537b14a6b8917b263dddd

Revision history for this message
LisAndi - Andi Becker - http://lisandi.com (lisandi) wrote :

We receive that error now in 21.04.2-testing

Your current SimpleSAMLPHP library version is out of date. You need to run "make cleanssphp && make ssphp".

When we enter "make cleanssphp && make ssphp" in th Mahara root directory it gives out the error:
make cleanssphp && make ssphp
make: *** No rule to make target 'cleanssphp'. Stop.

So how to get rid of that error?

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.