broken list sorting in user search screen

Bug #1710735 reported by Cecilia Vela Gurovic
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
High
Cecilia Vela Gurovic
17.04
Fix Released
High
Unassigned
17.10
Fix Released
High
Cecilia Vela Gurovic

Bug Description

In admin/users/search.php

the column headers don't sort the user lists by their field. They always sort by first name when clicking on them.

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/7928

Changed in mahara:
assignee: nobody → Cecilia Vela Gurovic (ceciliavg)
Changed in mahara:
status: New → Confirmed
Changed in mahara:
status: Confirmed → In Progress
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/7928
Committed: https://git.mahara.org/mahara/mahara/commit/3e31e8deb8ab6b869c1b9db49f5a8e944c0f8ad8
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 3e31e8deb8ab6b869c1b9db49f5a8e944c0f8ad8
Author: Cecilia Vela Gurovic <email address hidden>
Date: Tue Aug 15 10:58:58 2017 +1200

Bug 1710735: user list sorting by column field

sortby field was being forced to be 'lastname'
sortdir to be 'asc'
in the search url for each header.

behatnotneeded

Change-Id: I6c78eab1c8570bb0408c08a34d2f62890313085c

Revision history for this message
Robert Lyon (robertl-9) wrote :

This worked fine in 16.10 but got broken in 17.04 so will mark as high regression bug

Changed in mahara:
milestone: none → 17.10.0
status: In Progress → Fix Committed
importance: Undecided → High
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "17.04_STABLE" branch: https://reviews.mahara.org/7929

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/7929
Committed: https://git.mahara.org/mahara/mahara/commit/1be013b4d9a5cc9fd9b7e54951fb261c52d19941
Submitter: Robert Lyon (<email address hidden>)
Branch: 17.04_STABLE

commit 1be013b4d9a5cc9fd9b7e54951fb261c52d19941
Author: Cecilia Vela Gurovic <email address hidden>
Date: Tue Aug 15 10:58:58 2017 +1200

Bug 1710735: user list sorting by column field

sortby field was being forced to be 'lastname'
sortdir to be 'asc'
in the search url for each header.

behatnotneeded

Change-Id: I6c78eab1c8570bb0408c08a34d2f62890313085c
(cherry picked from commit 3e31e8deb8ab6b869c1b9db49f5a8e944c0f8ad8)

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.