Editing a table - editor's icons are not being displayed

Bug #1649319 reported by Paula
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
High
Cecilia Vela Gurovic
15.10
Fix Released
High
Unassigned
16.04
Fix Released
High
Unassigned
16.10
Fix Released
High
Unassigned
17.04
Fix Released
High
Cecilia Vela Gurovic

Bug Description

Mahara 16.04

When you try to edit a table, the icons with the different options (add row, delete row, etc.) doesn't show up in the editor. See the screenshot attached.

Already tested in different browsers (Chrome, Firefox, etc.).

Steps :

1 - edit a page
2 - add a table
3 - try to edit the table (you'll see the icons are missing)

Revision history for this message
Paula (paula-ardanza-menendez) wrote :
description: updated
description: updated
Changed in mahara:
status: New → Confirmed
importance: Undecided → High
Revision history for this message
Gilles-Philippe Leblanc (gilles-philippe-leblanc) wrote :

The problem is from the skin "light" in the TinyMCE theme. He miss the required font and :before css style to call the icons.
A workaround is to replace the call of the "light" skin to the "lightgray" default skin in the htdocs/lib/web.php file.

I don't know exactly where is came from the "light skin" but if its an adapted version from the link below, it has the same problem :
https://pixabay.com/fr/blog/posts/a-modern-custom-theme-for-tinymce-4-40/

Maybe a solution is to begin from the "lightgray" skin and to create a new one. Ex using this:
http://skin.tinymce.com/

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/7440

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/7440
Committed: https://git.mahara.org/mahara/mahara/commit/49b0a84612143038d5093098bb089a631a689872
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 49b0a84612143038d5093098bb089a631a689872
Author: Cecilia Vela Gurovic <email address hidden>
Date: Tue Feb 7 15:58:11 2017 +1300

Bug 1649319: TinyMCE skin changed from light to lightgray

Copied the font files from lightgray skin to light skin
as both skins shared the same kind of fonts from IcoMoon tool,
and lightgray's are more complete.

Added rules in skin.min.css to load the icons
in correct place.

behatnotneeded

Change-Id: Ibe0dea938aae6accdd6022572d79a649b6bf0324

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "16.10_STABLE" branch: https://reviews.mahara.org/7463

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "16.04_STABLE" branch: https://reviews.mahara.org/7464

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "15.10_STABLE" branch: https://reviews.mahara.org/7465

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/7464
Committed: https://git.mahara.org/mahara/mahara/commit/65c90c9ccbd983a3df7f49754c534c041ec8df4a
Submitter: Robert Lyon (<email address hidden>)
Branch: 16.04_STABLE

commit 65c90c9ccbd983a3df7f49754c534c041ec8df4a
Author: Cecilia Vela Gurovic <email address hidden>
Date: Tue Feb 7 15:58:11 2017 +1300

Bug 1649319: TinyMCE skin changed from light to lightgray

Copied the font files from lightgray skin to light skin
as both skins shared the same kind of fonts from IcoMoon tool,
and lightgray's are more complete.

Added rules in skin.min.css to load the icons
in correct place.

behatnotneeded

Change-Id: Ibe0dea938aae6accdd6022572d79a649b6bf0324
(cherry picked from commit 49b0a84612143038d5093098bb089a631a689872)

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/7465
Committed: https://git.mahara.org/mahara/mahara/commit/8566af4cab0b6ed7a3771f202ee8b36c647160bc
Submitter: Robert Lyon (<email address hidden>)
Branch: 15.10_STABLE

commit 8566af4cab0b6ed7a3771f202ee8b36c647160bc
Author: Cecilia Vela Gurovic <email address hidden>
Date: Tue Feb 7 15:58:11 2017 +1300

Bug 1649319: TinyMCE skin changed from light to lightgray

Copied the font files from lightgray skin to light skin
as both skins shared the same kind of fonts from IcoMoon tool,
and lightgray's are more complete.

Added rules in skin.min.css to load the icons
in correct place.

behatnotneeded

Change-Id: Ibe0dea938aae6accdd6022572d79a649b6bf0324
(cherry picked from commit 49b0a84612143038d5093098bb089a631a689872)

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/7463
Committed: https://git.mahara.org/mahara/mahara/commit/834287fd51b888a861137b8301797b58e772727b
Submitter: Robert Lyon (<email address hidden>)
Branch: 16.10_STABLE

commit 834287fd51b888a861137b8301797b58e772727b
Author: Cecilia Vela Gurovic <email address hidden>
Date: Tue Feb 7 15:58:11 2017 +1300

Bug 1649319: TinyMCE skin changed from light to lightgray

Copied the font files from lightgray skin to light skin
as both skins shared the same kind of fonts from IcoMoon tool,
and lightgray's are more complete.

Added rules in skin.min.css to load the icons
in correct place.

behatnotneeded

Change-Id: Ibe0dea938aae6accdd6022572d79a649b6bf0324
(cherry picked from commit 49b0a84612143038d5093098bb089a631a689872)

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.