Skin title shows escaped characters for single and double quotes

Bug #1706536 reported by Ghada El-Zoghbi
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Low
Ghada El-Zoghbi
16.04
Fix Released
Low
Unassigned
16.10
Fix Released
Low
Unassigned
17.04
Fix Released
Low
Unassigned
17.10
Fix Released
Low
Ghada El-Zoghbi

Bug Description

Mahara: 16.10.04 (version = 2016090224)
OS: Linux
DB: Postgres
Browser: FF

If the title of a skin has a single quote or double quotes, it is displayed with the escaped characters on the /skin/index.php page.

If my skin is called:

'Test quotes'

it is displayed as:

'Test quotes'

Revision history for this message
Ghada El-Zoghbi (ghada-z) wrote :
Revision history for this message
Ghada El-Zoghbi (ghada-z) wrote :

Steps to replicate:

* Log in as a user
* Create a skin
* Set title to: 'aaa bbb ccc'
* Save
* Skin is displayed with escaped characters.

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/7897

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/7897
Committed: https://git.mahara.org/mahara/mahara/commit/9635660f3a498fc9b383370046ae53660e4f265a
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 9635660f3a498fc9b383370046ae53660e4f265a
Author: Ghada El-Zoghbi <email address hidden>
Date: Wed Jul 26 17:49:10 2017 +1000

Bug #1706536: Mark the skin title safe when disaplying on screen.

Done for both raw and raw_old themes.

Sponsored by Australian National University

behatnotneeded

Change-Id: Id492639efed8a8562d2d6accfbacae1ed793f7f1

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "17.04_STABLE" branch: https://reviews.mahara.org/7898

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "16.10_STABLE" branch: https://reviews.mahara.org/7899

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "16.04_STABLE" branch: https://reviews.mahara.org/7900

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/7898
Committed: https://git.mahara.org/mahara/mahara/commit/caef297a356304d2588f4272d7e925a12c7ecc6a
Submitter: Robert Lyon (<email address hidden>)
Branch: 17.04_STABLE

commit caef297a356304d2588f4272d7e925a12c7ecc6a
Author: Ghada El-Zoghbi <email address hidden>
Date: Wed Jul 26 17:49:10 2017 +1000

Bug #1706536: Mark the skin title safe when disaplying on screen.

Done for both raw and raw_old themes.

Sponsored by Australian National University

behatnotneeded

Change-Id: Id492639efed8a8562d2d6accfbacae1ed793f7f1
(cherry picked from commit 9635660f3a498fc9b383370046ae53660e4f265a)

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/7900
Committed: https://git.mahara.org/mahara/mahara/commit/b3931cb2b71f7e1fb76cc99a98ce8b6cec5e5de2
Submitter: Robert Lyon (<email address hidden>)
Branch: 16.04_STABLE

commit b3931cb2b71f7e1fb76cc99a98ce8b6cec5e5de2
Author: Ghada El-Zoghbi <email address hidden>
Date: Wed Jul 26 17:49:10 2017 +1000

Bug #1706536: Mark the skin title safe when disaplying on screen.

Done for raw theme.

Sponsored by Australian National University

behatnotneeded

Change-Id: Id492639efed8a8562d2d6accfbacae1ed793f7f1
(cherry picked from commit 9635660f3a498fc9b383370046ae53660e4f265a)

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/7899
Committed: https://git.mahara.org/mahara/mahara/commit/0e0b209433196102d4e90f09fbf6f8ac06f810c9
Submitter: Robert Lyon (<email address hidden>)
Branch: 16.10_STABLE

commit 0e0b209433196102d4e90f09fbf6f8ac06f810c9
Author: Ghada El-Zoghbi <email address hidden>
Date: Wed Jul 26 17:49:10 2017 +1000

Bug #1706536: Mark the skin title safe when disaplying on screen.

Done for raw theme.

Sponsored by Australian National University

behatnotneeded

Change-Id: Id492639efed8a8562d2d6accfbacae1ed793f7f1
(cherry picked from commit 9635660f3a498fc9b383370046ae53660e4f265a)

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.