Annotation field can be left empty when adding annotation

Bug #1694875 reported by Kristina Hoeppner
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
High
Pramith Dayananda
16.10
Fix Released
High
Pramith Dayananda
17.04
Fix Released
High
Pramith Dayananda
17.10
Fix Released
High
Pramith Dayananda

Bug Description

Mahara 16.10 and 17.04+

When you add an annotation block, you are supposed to be required to provide an annotation in order to say why you align your portfolio with a particular standard.

The "Annotation" field (no matter whether added via the SmartEvidence map or as block) can be left empty though now when saving the block configuration. It can't be added later on.

The field should not be left empty though as the annotation is a vital aspect.

To replicate:

1. Add a collection with a SmartEvidence map.
2. Add an annotation via the SmartEvidence map.

Expected result: You can't save the configuration dialogue without typing an annotation.
Actual result: You can leave the field empty and save.

3. Add an annotation via the portfolio page.

Expected result: You can't save the configuration dialogue without typing an annotation.
Actual result: You can leave the field empty and save.

Tags: regression
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/7831

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "master" branch: https://reviews.mahara.org/7834

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "master" branch: https://reviews.mahara.org/7851

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/7831
Committed: https://git.mahara.org/mahara/mahara/commit/e87eac7477932125739ff5266aea3c68e1766905
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit e87eac7477932125739ff5266aea3c68e1766905
Author: Pramith Dayananda <email address hidden>
Date: Fri Jun 23 09:25:09 2017 +1200

Bug 1694875: Annotation field validated via JS

Validation on portfolio collections
Validation on smartevidence grid
Behat tests added
A new feature file added

Change-Id: Ib5adf627f3391fb53805b0566a7c405313a3066b

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "17.04_STABLE" branch: https://reviews.mahara.org/7975

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "master" branch: https://reviews.mahara.org/7976

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "16.10_STABLE" branch: https://reviews.mahara.org/7977

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "master" branch: https://reviews.mahara.org/7978

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "17.04_STABLE" branch: https://reviews.mahara.org/7991

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/7991
Committed: https://git.mahara.org/mahara/mahara/commit/d9d2cf34d00277d5e9dcd309eb93a4544f9b88a2
Submitter: Robert Lyon (<email address hidden>)
Branch: 17.04_STABLE

commit d9d2cf34d00277d5e9dcd309eb93a4544f9b88a2
Author: Robert Lyon <email address hidden>
Date: Wed Sep 6 08:59:16 2017 +1200

Bug 1694875: Getting annotation behat test to actually test right thing

Change-Id: I04cdd63a45484fd289fd6e90b5f3f135df8fda67
Signed-off-by: Robert Lyon <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/7975
Committed: https://git.mahara.org/mahara/mahara/commit/c2208ed41610fc547f69a46f4da2920583c16506
Submitter: Robert Lyon (<email address hidden>)
Branch: 17.04_STABLE

commit c2208ed41610fc547f69a46f4da2920583c16506
Author: Pramith Dayananda <email address hidden>
Date: Fri Jun 23 09:25:09 2017 +1200

Bug 1694875: Annotation field validated via JS

Validation on portfolio collections
Validation on smartevidence grid
Behat tests added
A new feature file added

Change-Id: Ib5adf627f3391fb53805b0566a7c405313a3066b

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "16.10_STABLE" branch: https://reviews.mahara.org/7997

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/7978
Committed: https://git.mahara.org/mahara/mahara/commit/4e1ba125c28cb9acc5dccba02ac0efc8e65a1db1
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 4e1ba125c28cb9acc5dccba02ac0efc8e65a1db1
Author: Robert Lyon <email address hidden>
Date: Wed Sep 6 08:59:16 2017 +1200

Bug 1694875: Getting annotation behat test to actually test right thing

Change-Id: I04cdd63a45484fd289fd6e90b5f3f135df8fda67
Signed-off-by: Robert Lyon <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/7977
Committed: https://git.mahara.org/mahara/mahara/commit/17531234868cb0dacf812a3d8ddcd2946714d84c
Submitter: Robert Lyon (<email address hidden>)
Branch: 16.10_STABLE

commit 17531234868cb0dacf812a3d8ddcd2946714d84c
Author: Pramith Dayananda <email address hidden>
Date: Fri Jun 23 09:25:09 2017 +1200

Bug 1694875: Annotation field validated via JS

Validation on portfolio collections
Validation on smartevidence grid
Behat tests added
A new feature file added

Change-Id: Ib5adf627f3391fb53805b0566a7c405313a3066b

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/7976
Committed: https://git.mahara.org/mahara/mahara/commit/10ebac849ce79b6a022431bbe84a8b441c734dc1
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 10ebac849ce79b6a022431bbe84a8b441c734dc1
Author: Robert Lyon <email address hidden>
Date: Tue Sep 5 08:02:55 2017 +1200

Bug 1694875: moving feature file to correct place for 17.10

Some patches that have been merged after the reorder behat tests patch
are placing the feature files in old places.

This patch moves them to new places

Change-Id: Iff93b45198f980a1e9553bb1d9e15c8ae9bec112
Signed-off-by: Robert Lyon <email address hidden>

Revision history for this message
Niranjan (niranjan528) wrote :

URL: https://bugs.launchpad.net/mahara/+bug/1694875

Bug description: Annotation field can be left empty when adding annotation.

Environment to be tested: 16.10_STABLE, 17.04_STABLE
Browser to be tested: Firefox, Chrome, Safari , IE ( Latest version)

Precondition:
1. A user with 'site admin' access should exist.
2. The institution 'Institution A' exists and the user is a member in that institution.
3. A collection should exist with the name 'Collection one' and pages 'Page 01' and 'Page 02'.

Steps to reproduce:

1. Log in as a site admin user.
2. Navigate to Administration menu > Institutions.
3. Click the ‘Settings’ under ‘Institution A’.
4. Set the switch ‘Allow SmartEvidence’ to ‘Yes’.
5. Click the ‘Submit’ button.
6. Navigate to Administration menu > Extensions > Plugin administration.
7. Click the 'Show' button for the plugin ‘annotation/annotation’.
8. Navigate to Main menu > Portfolio > Pages and collections.
9. Click the 'More' icon for 'Collection one' and then the 'Edit' icon.
10. Select a SmartEvidence framework to associate with the collection.
11. Click the ‘Save’ button and view the collection.
12. Click one of the dot icons in the matrix for 'Page 01'.
13. Click the ‘Save’ button without entering any text into the ‘Annotation’ description.

Expected result: You see an error message: ‘You can't save the configuration dialogue without typing an annotation.’

14. Enter text into the annotation field and click the 'Save' button.

Expected result: The form is saved correctly and you are returned to the matrix page. The dot icon will have changed to a blue circle.

15. Click the ‘Next page’ button.
16. Click the ‘Edit this page’ button.
17. Expand the ‘General’ panel.
18. Click on ‘Annotation’.
19. Click the ‘Add’ button.
20. Click the ‘Save’ button without entering any text into the ‘Annotation’ description.

Expected result: You see an error message ‘You can't save the configuration dialogue without typing an annotation.’

21. Enter text into the annotation field and click the 'Save' button.

Expected result: The form is saved correctly and you are returned to the
edit screen of the page where you can now see the annotation block.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.