Activity log for bug #1636854

Date Who What changed Old value New value Message
2016-10-26 13:32:45 Kevin Rickis bug added bug
2016-10-26 14:07:50 Kevin Rickis description Hi I'm trying a clean install of Mahara 16.10.0 and I'm getting this error. Parse error: syntax error, unexpected ''login_submitted'' (T_CONSTANT_ENCAPSED_STRING) in /mnt/data1/www/m1610.edictdev.co.uk/httpdocs/auth/lib.php on line 1443 Looking at the code I think there might have been a copy and paste error as you cannot check for empty('login_submitted'). My guess is that it should be $values? Function below. Kevin /** * Called when the login form is being validated during submission. * Checks the user and password fields are filled in. * * @param object $form The Pieform form object * @param array $values The submitted values */ function login_validate(Pieform $form, $values) { if (!empty('login_submitted')) { if (empty($values['login_username']) || empty($values['login_password'])) { $form->set_error(null, get_string('loginfailed')); } } } Hi I'm trying a clean install of Mahara 16.10.0 on a server running PHP 5.4 and I'm getting this error. Parse error: syntax error, unexpected ''login_submitted'' (T_CONSTANT_ENCAPSED_STRING) in /mnt/data1/www/m1610.edictdev.co.uk/httpdocs/auth/lib.php on line 1443 Looking at the code I think there might have been a copy and paste error as you cannot check for empty('login_submitted'). My guess is that it should be $values? Function below. Kevin /**  * Called when the login form is being validated during submission.  * Checks the user and password fields are filled in.  *  * @param object $form The Pieform form object  * @param array $values The submitted values  */ function login_validate(Pieform $form, $values) {     if (!empty('login_submitted')) {         if (empty($values['login_username']) || empty($values['login_password'])) {             $form->set_error(null, get_string('loginfailed'));         }     } }
2016-10-26 19:36:06 Robert Lyon mahara: importance Undecided Medium
2016-10-26 19:36:10 Robert Lyon mahara: importance Medium High
2016-10-26 19:36:14 Robert Lyon mahara: assignee Robert Lyon (robertl-9)
2016-10-26 19:36:16 Robert Lyon mahara: milestone 17.04.0
2016-10-26 19:36:18 Robert Lyon mahara: status New In Progress
2016-10-26 19:36:23 Robert Lyon nominated for series mahara/16.10
2016-10-26 19:36:23 Robert Lyon bug task added mahara/16.10
2016-10-26 19:36:28 Robert Lyon mahara/16.10: importance Undecided High
2016-10-26 19:36:31 Robert Lyon mahara/16.10: milestone 16.10.1
2016-10-26 19:36:35 Robert Lyon mahara/16.10: status New Confirmed
2016-11-01 20:41:17 Robert Lyon mahara: status In Progress Fix Committed
2016-11-01 20:41:18 Robert Lyon mahara/16.10: status Confirmed Fix Committed
2016-12-13 01:01:39 Cecilia Vela Gurovic mahara/16.10: status Fix Committed Fix Released
2017-04-27 05:04:51 Robert Lyon mahara: status Fix Committed Fix Released