Journals that you can't add entries to appear in drop-down for "Add new entry" in "Recent journal entries" block

[Kristina Hoeppner]

16.04.rc1

You can place the "Recent journal entries" block on any page and when you place it on a personal or group page, you also see other journals, e.g. institution and site (on a personal page) and site (on a group page). However, when you include these journals in your block, they also appear in the drop-down menu where you can choose in which journal you want to create a new entry.

When you choose an institution or site journal and are not an institution admin or site admin, you only see:

Access denied
You do not have access to view this page.

[[youarenotasiteadmin/artefact.blog]]

You should not be able to see the journals in the drop-down menu to which you cannot add an entry.

There are other two related bugs that should be fixed at the same time:
1. Bug #1565198: "Recent journal entries" block should mention journal context in config
2. Bug #1565197: Selecting "Site journal" in "Recent journal entries" block in a group just spins

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/7191

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/7191
Committed: https://git.mahara.org/mahara/mahara/commit/88b94532101fd84acf132779a1dc1ad89f74188d
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 88b94532101fd84acf132779a1dc1ad89f74188d
Author: Cecilia Vela Gurovic <email address hidden>
Date: Fri Oct 21 10:06:56 2016 +1300

Bug 1565199: Filter Recent Journals block Add entry + errors

In the block Recent journal entries, the drop-down menu
only shows the Journals which the user has permission to
add a new entry.

Also corrected error showing up and broken Journal search
in the Edit block side screen.

Also fixed the poor alignment of the artefactchoooser search form's
search button

Also fixes Bug 1636850 with change in lib/view.php

behatnotneeded

Change-Id: I44c0d6d25eda7cb37d4a8aab66a6d1b93ca60b69

[Mahara Bot (dev-mahara)]

Patch for "16.10_STABLE" branch: https://reviews.mahara.org/7252

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/7252
Committed: https://git.mahara.org/mahara/mahara/commit/e08db4cd65c277d77eb658b33447779a8985c362
Submitter: Robert Lyon (<email address hidden>)
Branch: 16.10_STABLE

commit e08db4cd65c277d77eb658b33447779a8985c362
Author: Cecilia Vela Gurovic <email address hidden>
Date: Fri Oct 21 10:06:56 2016 +1300

Bug 1565199: Filter Recent Journals block Add entry + errors

In the block Recent journal entries, the drop-down menu
only shows the Journals which the user has permission to
add a new entry.

Also corrected error showing up and broken Journal search
in the Edit block side screen.

Also fixed the poor alignment of the artefactchoooser search form's
search button

Also fixes Bug 1636850 with change in lib/view.php

behatnotneeded

Change-Id: I44c0d6d25eda7cb37d4a8aab66a6d1b93ca60b69
(cherry picked from commit 88b94532101fd84acf132779a1dc1ad89f74188d)