Feedback count for annotations doesn't update until you refresh the page

[Aaron Wells]

As reported on https://reviews.mahara.org/#/c/4123/:

"When adding feedback, the feedback count is not increased until you refresh the page. We don't have that problem with the comments functionality as comments are left on the artefact details page and not on the portfolio page. This is a minor thing and we could leave it for last to change."

[Kristina Hoeppner (kris-hoeppner)]

On 15.10 I get the following error message:

[WAR] 45 (artefact/annotation/lib.php:1764) Undefined offset: 0
Call stack (most recent first):

    log_message("Undefined offset: 0", 8, true, true, "/home/kristina/code/mahara/htdocs/artefact/annotat...", 1764) at /home/kristina/code/mahara/htdocs/lib/errors.php:441
    error(8, "Undefined offset: 0", "/home/kristina/code/mahara/htdocs/artefact/annotat...", 1764, array(size 13)) at /home/kristina/code/mahara/htdocs/artefact/annotation/lib.php:1764
    ActivityTypeArtefactAnnotationAnnotationfeedback->__construct(object(stdClass), false) at /home/kristina/code/mahara/htdocs/lib/activity.php:69
    handle_activity(object(stdClass), object(stdClass)) at /home/kristina/code/mahara/htdocs/lib/activity.php:42
    activity_occurred("annotationfeedback", object(stdClass), "artefact", "annotation") at /home/kristina/code/mahara/htdocs/artefact/annotation/lib.php:1629
    add_annotation_feedback_form_submit(object(Pieform), array(size 8)) at Unknown:0
    call_user_func_array("add_annotation_feedback_form_submit", array(size 2)) at /home/kristina/code/mahara/htdocs/lib/pieforms/pieform.php:537
    Pieform->__construct(array(size 11)) at /home/kristina/code/mahara/htdocs/lib/pieforms/pieform.php:164
    Pieform::process(array(size 11)) at /home/kristina/code/mahara/htdocs/lib/pieforms/pieform.php:71
    pieform(array(size 11)) at /home/kristina/code/mahara/htdocs/artefact/annotation/lib.php:965
    ArtefactTypeAnnotationfeedback::get_annotation_feedback_for_view(object(ArtefactTypeAnnotation), object(View), "6140", true, false) at /home/kristina/code/mahara/htdocs/artefact/annotation/blocktype/annotation/lib.php:138
    PluginBlocktypeAnnotation::render_instance(object(BlockInstance)) at Unknown:0
    call_user_func_array(array(size 2), array(size 1)) at /home/kristina/code/mahara/htdocs/lib/mahara.php:1655
    call_static_method("PluginBlocktypeAnnotation", "render_instance", object(BlockInstance)) at /home/kristina/code/mahara/htdocs/blocktype/lib.php:942
    BlockInstance->render_viewing(false) at /home/kristina/code/mahara/htdocs/lib/view.php:2070
    View->build_column(1, 3, false, false) at /home/kristina/code/mahara/htdocs/lib/view.php:2024
    View->build_columns(1, false, false) at /home/kristina/code/mahara/htdocs/lib/view.php:2009
    View->build_rows() at /home/kristina/code/mahara/htdocs/view/view.php:265

----------------

It also doesn't display the Feedback count.

Robert fixed something that might be similar: Wall posts were also not showing until you refreshed the page.

[Robert Lyon (robertl-9)]

The error in #1 is now fixed so will drop the importance as a page refresh will show the correct info

[Robert Lyon (robertl-9)]

This should now be fixed by https://reviews.mahara.org/#/c/7187/ and by Bug 1632865