Login box lang strings don't change when language is switched

Bug #1496681 reported by Kristina Hoeppner
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
High
Unassigned
1.10
Fix Released
High
Unassigned
1.9
Fix Released
High
Unassigned
15.04
Fix Released
High
Unassigned
16.04
Fix Released
High
Unassigned

Bug Description

Evonne found the following on her instance of 15.10dev:

When she changes the language and clicks the "Change" button, the inside of the login box is not changed. She needs to refresh the page to get the other language's strings. The text in the middle and also the "Links and resources" strings change. The title of the login box changes, but not "Username", "Password", the register etc. links and the help.

Tags: regression
Revision history for this message
Aaron Wells (u-aaronw) wrote :

This patch, for Bug 1495200, also resolve this issue: https://reviews.mahara.org/#/c/5407/

Revision history for this message
Aaron Wells (u-aaronw) wrote :

Testing indicates this is present in all versions of Mahara from 1.9 (which is when we added the patch that puts the login form into the session)

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/5407
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/aee374c0aa5d89cadba50a2eff2891af4ee751c0
Submitter: Robert Lyon (<email address hidden>)
Branch: 15.04_STABLE

commit aee374c0aa5d89cadba50a2eff2891af4ee751c0
Author: Aaron Wells <email address hidden>
Date: Wed Sep 30 17:15:49 2015 +1300

Remove unnecessary cached form from the session

Bug 1495200 & Bug 1496681

behatnotneeded: Well, we could test this, but it would
require a 60-second wait for the session to timeout (since
the least you can set the session timeout via the UI
is 1 minute)

Change-Id: Ia5c861c16b6c893ada9d5eb2111f0b6a9aee49ad

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "15.10_STABLE" branch: https://reviews.mahara.org/5441

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/5441
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/784dbf9d5a5a8fc31a7d5b49bbcb41fe68578b7b
Submitter: Robert Lyon (<email address hidden>)
Branch: 15.10_STABLE

commit 784dbf9d5a5a8fc31a7d5b49bbcb41fe68578b7b
Author: Aaron Wells <email address hidden>
Date: Wed Sep 30 17:15:49 2015 +1300

Remove unnecessary cached form from the session

Bug 1495200 & Bug 1496681

behatnotneeded: Well, we could test this, but it would
require a 60-second wait for the session to timeout (since
the least you can set the session timeout via the UI
is 1 minute)

Change-Id: Ia5c861c16b6c893ada9d5eb2111f0b6a9aee49ad
(cherry picked from commit aee374c0aa5d89cadba50a2eff2891af4ee751c0)

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/5442

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/5442
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/e2d001a8873c3897ef088d6ed609f11846c82c41
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit e2d001a8873c3897ef088d6ed609f11846c82c41
Author: Aaron Wells <email address hidden>
Date: Wed Sep 30 17:15:49 2015 +1300

Remove unnecessary cached form from the session

Bug 1495200 & Bug 1496681

behatnotneeded: Well, we could test this, but it would
require a 60-second wait for the session to timeout (since
the least you can set the session timeout via the UI
is 1 minute)

Change-Id: Ia5c861c16b6c893ada9d5eb2111f0b6a9aee49ad
(cherry picked from commit aee374c0aa5d89cadba50a2eff2891af4ee751c0)
(cherry picked from commit 784dbf9d5a5a8fc31a7d5b49bbcb41fe68578b7b)

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "1.10_STABLE" branch: https://reviews.mahara.org/5443

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "1.9_STABLE" branch: https://reviews.mahara.org/5444

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/5444
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/af0f74a9dafa0b3726df925e65c1443f7aa2e29a
Submitter: Robert Lyon (<email address hidden>)
Branch: 1.9_STABLE

commit af0f74a9dafa0b3726df925e65c1443f7aa2e29a
Author: Aaron Wells <email address hidden>
Date: Wed Sep 30 17:15:49 2015 +1300

Remove unnecessary cached form from the session

Bug 1495200 & Bug 1496681

behatnotneeded: Well, we could test this, but it would
require a 60-second wait for the session to timeout (since
the least you can set the session timeout via the UI
is 1 minute)

Change-Id: Ia5c861c16b6c893ada9d5eb2111f0b6a9aee49ad
(cherry picked from commit aee374c0aa5d89cadba50a2eff2891af4ee751c0)
(cherry picked from commit 784dbf9d5a5a8fc31a7d5b49bbcb41fe68578b7b)

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/5443
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/ea1bdc16d53ac5c659a9df853fae8fa891102e51
Submitter: Robert Lyon (<email address hidden>)
Branch: 1.10_STABLE

commit ea1bdc16d53ac5c659a9df853fae8fa891102e51
Author: Aaron Wells <email address hidden>
Date: Wed Sep 30 17:15:49 2015 +1300

Remove unnecessary cached form from the session

Bug 1495200 & Bug 1496681

behatnotneeded: Well, we could test this, but it would
require a 60-second wait for the session to timeout (since
the least you can set the session timeout via the UI
is 1 minute)

Change-Id: Ia5c861c16b6c893ada9d5eb2111f0b6a9aee49ad
(cherry picked from commit aee374c0aa5d89cadba50a2eff2891af4ee751c0)
(cherry picked from commit 784dbf9d5a5a8fc31a7d5b49bbcb41fe68578b7b)

no longer affects: mahara/15.10
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.