Mahara

Imagebrowser tinymce plugin missing strings

  1. Series 15.10
  2. Bug #1440947
Bug #1440947 reported by Jinelle Foley-Barnes
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
High
Robert Lyon
Mahara 15.04.0
15.04
Fix Released
High
Robert Lyon
Mahara 15.04.0
15.10
Fix Released
High
Unassigned
Mahara 15.10.0

Bug Description

Hi,

When I create a forum and add a pic into the description, the remove button has [[remove]] around it.

I have attached a screen shot.

If you need anymore info let me know.

Cheers,
Jinelle

Revision history for this message
Jinelle Foley-Barnes (jinelleb) wrote :
Changed in mahara:
milestone: none → 1.10.3
Robert Lyon (robertl-9)
summary: - Forum button string has brackets around it
+ Imagebrowser tinymce plugin missing strings
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/4589

Revision history for this message
Robert Lyon (robertl-9) wrote :

The TinyMCE imagebrowser does not have access to certain strings when outside the view/blocks.php page.

It has the strings in view/blocks.php due to that page also having a filebrowser pieform present that contains the lang strings we need.

So to fix this we need to first look in lib/form/elements/filebrowser.php and within the pieform_element_filebrowser_get_headdata() at about lines 1498-1505 we see the $strings bit that we need.

We need to add that to the pieform_element_wysiwyg_get_headdata() in lib/form/elements/wysiwyg.php

Changed in mahara:
status: New → In Progress
importance: Undecided → High
assignee: nobody → Robert Lyon (robertl-9)
milestone: 1.10.3 → 15.04.0
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/4589
Committed: http://gitorious.org/mahara/mahara/commit/b804652eab492c7634835725c24b3ee13defc8e5
Submitter: Aaron Wells (<email address hidden>)
Branch: master

commit b804652eab492c7634835725c24b3ee13defc8e5
Author: Bob Lyon <email address hidden>
Date: Wed Apr 8 10:49:49 2015 +1200

Allowing the tinymce imagebrowser to have lang strings (Bug #1440947)

when the tinymce is not on the view/blocks.php page

Change-Id: Ie477c41ac2143fae2017f4d3251daa11cf41f97b
Signed-off-by: Bob Lyon <email address hidden>

Aaron Wells (u-aaronw)
tags: added: regression
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "15.04_STABLE" branch: https://reviews.mahara.org/4611

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/4611
Committed: http://gitorious.org/mahara/mahara/commit/f59c680623b84652342271adf612ce9fa10ad667
Submitter: Robert Lyon (<email address hidden>)
Branch: 15.04_STABLE

commit f59c680623b84652342271adf612ce9fa10ad667
Author: Bob Lyon <email address hidden>
Date: Wed Apr 8 10:49:49 2015 +1200

Allowing the tinymce imagebrowser to have lang strings (Bug #1440947)

when the tinymce is not on the view/blocks.php page

Change-Id: Ie477c41ac2143fae2017f4d3251daa11cf41f97b
Signed-off-by: Bob Lyon <email address hidden>

Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
Jinelle Foley-Barnes (jinelleb)
tags: added: needs-behat
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.