Behat tests: Removing duplicates and tidying tests

Bug #1446395 reported by Jinelle Foley-Barnes
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
High
Jinelle Foley-Barnes
15.04
Invalid
High
Unassigned
15.10
Fix Released
High
Jinelle Foley-Barnes

Bug Description

Hi All,

The suite needs a little maintenance and tidying. In order to make the tests run faster and be more efficient we need to tidy the tests up. Eg: put them into the correct folders, make sure they have appropriate tags for running them in groups, delete those that are testing duplicate things and also delete those that are directly duplicate tests.

Thanks,
Jinelle

Tags: behat
Aaron Wells (u-aaronw)
Changed in mahara:
milestone: 15.04.1 → 15.10.0
Revision history for this message
Robert Lyon (robertl-9) wrote :

Changed importance to high as the rationalization of the tests should speed up the behat test suite

Changed in mahara:
status: New → In Progress
importance: Undecided → High
assignee: nobody → Jinelle Foley-Barnes (jinelleb)
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/4672
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/378891f9e97d1d0d53c111f2fbfcba01cb7e8b4c
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 378891f9e97d1d0d53c111f2fbfcba01cb7e8b4c
Author: Jinelle Foley-Barnes <email address hidden>
Date: Mon Apr 20 16:02:53 2015 +1200

Behat Testsuite: Tidying up institution features (Bug #1446395)

To view the changes /tests/behat/feature/institutions

I got rid of redundancies

Change-Id: Ifdcc1920eaa168ddfd845e8f0d92acdd5a98665b

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/4675
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/2f96576cf30b33844abb3522ebe9ad9906f3507b
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 2f96576cf30b33844abb3522ebe9ad9906f3507b
Author: Jinelle Foley-Barnes <email address hidden>
Date: Mon Apr 20 17:36:04 2015 +1200

Behat Testsuite: Tidying up View feature files (Bug #1446395)

/test/behat/features/view

I tidied up these tests and deleted redundant ones, and deleted some of the original tests
Sonn wrote when we set up the suite. I took note of which ones and I'm going to rewrite news ones that have more
coverage and use fixtures so they run faster.

Change-Id: I555f2942ea213f2f73a13a3f5cd8c717df0b2dd2

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/4674
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/05970a94e5c9047714528dd39cc7d85cd65110d3
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 05970a94e5c9047714528dd39cc7d85cd65110d3
Author: Jinelle Foley-Barnes <email address hidden>
Date: Mon Apr 20 17:15:24 2015 +1200

Behat Testsuite: Tidying up the User features (Bug #1446395)

/test/behat/features/user

I have tidyed up and deleted duplicates of the tests.

Change-Id: I2274505be97c7a29c603c826b83cfb471ebb9bd7

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/4673
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/e192884fb4dfed13ba359312cbd23757a14a76f6
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit e192884fb4dfed13ba359312cbd23757a14a76f6
Author: Jinelle Foley-Barnes <email address hidden>
Date: Mon Apr 20 16:34:13 2015 +1200

Behat Testsuite: Tidying up messages files (Bug #1446395)

Located in /tests/behat/features/messages

Change-Id: I2f1d41e42d63bbf49f2a4e64c60cd22a6de300d6

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/4669
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/67472674e099a0f2d278cabc66c7737279c015e2
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 67472674e099a0f2d278cabc66c7737279c015e2
Author: Jinelle Foley-Barnes <email address hidden>
Date: Mon Apr 20 14:50:32 2015 +1200

Behat Testsuite: Tidying admin feature files (Bug #1446395)

To see what's been changed look in /test/behat/features/admin

Change-Id: Ic768495672c15ab9eb99ae902ff2a587e5d191eb

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/4668
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/3fb0deed03a7d70058576a37583d2032d84bcf2c
Submitter: Aaron Wells (<email address hidden>)
Branch: master

commit 3fb0deed03a7d70058576a37583d2032d84bcf2c
Author: Jinelle Foley-Barnes <email address hidden>
Date: Mon Apr 20 14:17:38 2015 +1200

Behat Testsuite: Tidying up account features (Bug #1446395)

I've cleaned up the tests in the test/behat/features/account area

That inc, tags at the top to run the tests and duplicate tests

Change-Id: I8891fb65e33826b26955bc47ef9ff97141fed558

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/4670
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/2bb6e75cdfd0dda51bd4ae7584404c17de465a9a
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 2bb6e75cdfd0dda51bd4ae7584404c17de465a9a
Author: Jinelle Foley-Barnes <email address hidden>
Date: Mon Apr 20 15:36:25 2015 +1200

Behat Testsuite: Tidying features in Artefact (Bug #1446395)

To find the files /test/behat/features/artefact
I tidyed the tags and made the tests run faster but adding fixtures that go directly
to the DB instead of inidividual steps

Change-Id: Id08eba12e36772ada6410c9b708fd815feae112f

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "15.04_STABLE" branch: https://reviews.mahara.org/6122

Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.