CSS is not stripping out bad css attributes anymore
Bug #1384467 reported by
Robert Lyon
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Mahara |
Fix Released
|
High
|
Son Nguyen | ||
1.10 |
Fix Released
|
High
|
Son Nguyen | ||
15.04 |
Fix Released
|
High
|
Son Nguyen |
Bug Description
If I add some custom CSS to a skin that has badly formed css it doesn't strip out the bad lines.
eg:
#footer {
color: #deface;
top:cat;
width: 300px;
odd:fellow;
}
It used to strip it down to leave the valid lines.
eg:
#footer {
color: #deface;
width: 300px;
}
This looks to have been broken with this patch https:/
Well not broken as such but the $preserve_css should be able to be set via either the site config or directly in the config.php file so that only sites that want to allow things like comments in the css can turn it on rather than it be on by default for the skins.
It still strips out html tags - so that is good
Changed in mahara: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Hi Robert,
It'd be better to fix this issue as these bad CSS settings should be stripped out