Mahara

Bad help box styling in "fresh" theme

  1. Series 1.9
  2. Bug #1508693
Bug #1508693 reported by Aaron Wells
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Unassigned
1.10
Fix Released
Medium
Unassigned
Mahara 1.10.8
1.9
Fix Released
Medium
Unassigned
Mahara 1.9.9
15.04
Fix Released
Medium
Unassigned
Mahara 15.04.4

Bug Description

Reported on the forums: https://mahara.org/interaction/forum/topic.php?id=7415&offset=0&limit=10#post29802

In the 15.04 "fresh" theme, the pop-up help box is hard to read because of its CSS styling.

Tags: theming
Revision history for this message
Aaron Wells (u-aaronw) wrote :

It turns out this problem goes back at least to Mahara 1.9. It won't be a problem in 15.10+, because we've eliminated the "fresh" theme.

Changed in mahara:
status: New → Confirmed
importance: Undecided → Medium
milestone: none → 15.04.5
tags: added: theming
Changed in mahara:
milestone: 15.04.5 → none
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "15.04_STABLE" branch: https://reviews.mahara.org/5624

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/5624
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/c3e49d5ce1334d4964387482765cf727c48d94fa
Submitter: Robert Lyon (<email address hidden>)
Branch: 15.04_STABLE

commit c3e49d5ce1334d4964387482765cf727c48d94fa
Author: Robert Lyon <email address hidden>
Date: Tue Oct 27 11:11:42 2015 +1300

Bug 1508693: Making help popup use same colours as block config popup

So that the help text can be read in the "Fresh" theme

behatnotneeded: Behat can't tell if colour contrast is bad

Change-Id: I66842fcd7f86bade5a8ed5100a38726d4067d9ea
Signed-off-by: Robert Lyon <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "1.10_STABLE" branch: https://reviews.mahara.org/5628

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "1.9_STABLE" branch: https://reviews.mahara.org/5629

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/5629
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/c02c7a72d6cdcca6c6646e5f84214c4040cedca6
Submitter: Robert Lyon (<email address hidden>)
Branch: 1.9_STABLE

commit c02c7a72d6cdcca6c6646e5f84214c4040cedca6
Author: Robert Lyon <email address hidden>
Date: Tue Oct 27 11:11:42 2015 +1300

Bug 1508693: Making help popup use same colours as block config popup

So that the help text can be read in the "Fresh" theme

behatnotneeded: Behat can't tell if colour contrast is bad

Change-Id: I66842fcd7f86bade5a8ed5100a38726d4067d9ea
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit c3e49d5ce1334d4964387482765cf727c48d94fa)

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/5628
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/505463ae11d8e58bb54a9e6b59e5508162b86940
Submitter: Robert Lyon (<email address hidden>)
Branch: 1.10_STABLE

commit 505463ae11d8e58bb54a9e6b59e5508162b86940
Author: Robert Lyon <email address hidden>
Date: Tue Oct 27 11:11:42 2015 +1300

Bug 1508693: Making help popup use same colours as block config popup

So that the help text can be read in the "Fresh" theme

behatnotneeded: Behat can't tell if colour contrast is bad

Change-Id: I66842fcd7f86bade5a8ed5100a38726d4067d9ea
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit c3e49d5ce1334d4964387482765cf727c48d94fa)

Robert Lyon (robertl-9)
Changed in mahara:
status: Confirmed → Fix Committed
Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.