Clicking 'more' in friend request is not working

Bug #1440908 reported by Dirk Meyer on 2015-04-06
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
High
Robert Lyon
1.10
High
Unassigned
1.8
High
Unassigned
1.9
High
Unassigned
15.04
High
Robert Lyon
15.10
High
Unassigned

Bug Description

After a friend request has been accepted, the notification is send and appears in my inbox. Clicking on 'More...' at the bottom of that message produces an 'Not found' error while it redirects using the following URL structure:

http://mymahara.com/http://mymahara.com/user/view.php?id=2

Dirk Meyer (dirkca68) wrote :

version and server:
15.04rc1
Debian
Mysql

Robert Lyon (robertl-9) on 2015-04-06
Changed in mahara:
status: New → In Progress
importance: Undecided → High
assignee: nobody → Robert Lyon (robertl-9)
milestone: none → 15.04.0
Mahara Bot (dev-mahara) wrote :

Patch for "master" branch: https://reviews.mahara.org/4594

Reviewed: https://reviews.mahara.org/4594
Committed: http://gitorious.org/mahara/mahara/commit/e01e1038dcfbf49cb1aec4345a1aefdf8ac9369d
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit e01e1038dcfbf49cb1aec4345a1aefdf8ac9369d
Author: Jinelle Foley-Barnes <email address hidden>
Date: Mon Apr 13 17:15:34 2015 +1200

Behat Test: Friend Request (Bug 1440908)

Change-Id: I6b01fec859e1384d8dedd3c134becb43c000bc24

Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/4581
Committed: http://gitorious.org/mahara/mahara/commit/5344f3da1eee29c7cf1b7ebd8270d7e97e996377
Submitter: Aaron Wells (<email address hidden>)
Branch: master

commit 5344f3da1eee29c7cf1b7ebd8270d7e97e996377
Author: Robert Lyon <email address hidden>
Date: Tue Apr 7 11:05:22 2015 +1200

The accepting friend notification contains full url (Bug #1440908)

And this ends up breaking the 'more' link in the inbox.

Normally we don't expect the url to contain the full path so we need
strip it off as it's added back in via the template.

Change-Id: Ibf22f361aaf7697e9903a2374f15d4fb031d01ef
Signed-off-by: Robert Lyon <email address hidden>

Mahara Bot (dev-mahara) wrote :

Patch for "1.8_STABLE" branch: https://reviews.mahara.org/4625

Reviewed: https://reviews.mahara.org/4625
Committed: http://gitorious.org/mahara/mahara/commit/90a422909a63e66b63e18278d460d07d1c3866bd
Submitter: Aaron Wells (<email address hidden>)
Branch: 1.8_STABLE

commit 90a422909a63e66b63e18278d460d07d1c3866bd
Author: Robert Lyon <email address hidden>
Date: Tue Apr 7 11:05:22 2015 +1200

The accepting friend notification contains full url (Bug #1440908)

And this ends up breaking the 'more' link in the inbox.

Normally we don't expect the url to contain the full path so we need
strip it off as it's added back in via the template.

Change-Id: Ibf22f361aaf7697e9903a2374f15d4fb031d01ef
Signed-off-by: Robert Lyon <email address hidden>

Reviewed: https://reviews.mahara.org/4626
Committed: http://gitorious.org/mahara/mahara/commit/6049db958b281097c20fec1979f7fbc87fe2061c
Submitter: Aaron Wells (<email address hidden>)
Branch: 1.9_STABLE

commit 6049db958b281097c20fec1979f7fbc87fe2061c
Author: Robert Lyon <email address hidden>
Date: Tue Apr 7 11:05:22 2015 +1200

The accepting friend notification contains full url (Bug #1440908)

And this ends up breaking the 'more' link in the inbox.

Normally we don't expect the url to contain the full path so we need
strip it off as it's added back in via the template.

Change-Id: Ibf22f361aaf7697e9903a2374f15d4fb031d01ef
Signed-off-by: Robert Lyon <email address hidden>

Reviewed: https://reviews.mahara.org/4627
Committed: http://gitorious.org/mahara/mahara/commit/aa9452a82e3dfd56ac78c2ea6d1639749ac89547
Submitter: Aaron Wells (<email address hidden>)
Branch: 1.10_STABLE

commit aa9452a82e3dfd56ac78c2ea6d1639749ac89547
Author: Robert Lyon <email address hidden>
Date: Tue Apr 7 11:05:22 2015 +1200

The accepting friend notification contains full url (Bug #1440908)

And this ends up breaking the 'more' link in the inbox.

Normally we don't expect the url to contain the full path so we need
strip it off as it's added back in via the template.

Change-Id: Ibf22f361aaf7697e9903a2374f15d4fb031d01ef
Signed-off-by: Robert Lyon <email address hidden>

Reviewed: https://reviews.mahara.org/4624
Committed: http://gitorious.org/mahara/mahara/commit/ea5d65803f99e2dbeddae007e2ef0a28d4510049
Submitter: Robert Lyon (<email address hidden>)
Branch: 15.04_STABLE

commit ea5d65803f99e2dbeddae007e2ef0a28d4510049
Author: Robert Lyon <email address hidden>
Date: Tue Apr 7 11:05:22 2015 +1200

The accepting friend notification contains full url (Bug #1440908)

And this ends up breaking the 'more' link in the inbox.

Normally we don't expect the url to contain the full path so we need
strip it off as it's added back in via the template.

Change-Id: Ibf22f361aaf7697e9903a2374f15d4fb031d01ef
Signed-off-by: Robert Lyon <email address hidden>

Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/4631
Committed: http://gitorious.org/mahara/mahara/commit/3e113992fbef287d58f76b2846299e1adc2373c3
Submitter: Robert Lyon (<email address hidden>)
Branch: 15.04_STABLE

commit 3e113992fbef287d58f76b2846299e1adc2373c3
Author: Jinelle Foley-Barnes <email address hidden>
Date: Mon Apr 13 17:15:34 2015 +1200

Behat Test: Friend Request (Bug 1440908)

Change-Id: I6b01fec859e1384d8dedd3c134becb43c000bc24

Reviewed: https://reviews.mahara.org/4651
Committed: http://gitorious.org/mahara/mahara/commit/32d0a3835510d063fa0383b87ac62539d7464adb
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 32d0a3835510d063fa0383b87ac62539d7464adb
Author: Robert Lyon <email address hidden>
Date: Thu Apr 16 17:41:37 2015 +1200

Bug 1440908: Fixing problem with friend_request.feature

Was trying to access 'Pete Mc' but the link for first and last name
are separate on the admin/users/search.php page so we need to just
look for the first name

Change-Id: I42778395f8c1b77cf2bb40333c1d3fd935802ecb
Signed-off-by: Robert Lyon <email address hidden>

Reviewed: https://reviews.mahara.org/4652
Committed: http://gitorious.org/mahara/mahara/commit/1a3114362336665641cce2678e4e23a71837f1de
Submitter: Robert Lyon (<email address hidden>)
Branch: 15.04_STABLE

commit 1a3114362336665641cce2678e4e23a71837f1de
Author: Robert Lyon <email address hidden>
Date: Thu Apr 16 17:41:37 2015 +1200

Bug 1440908: Fixing problem with friend_request.feature

Was trying to access 'Pete Mc' but the link for first and last name
are separate on the admin/users/search.php page so we need to just
look for the first name

Change-Id: I42778395f8c1b77cf2bb40333c1d3fd935802ecb
Signed-off-by: Robert Lyon <email address hidden>

Robert Lyon (robertl-9) on 2015-04-17
Changed in mahara:
status: Fix Committed → Fix Released
tags: added: behat has-behat
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers