Use the same paginator throughout

Bug #995761 reported by Kristina Hoeppner on 2012-05-07
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Mahara
Low
Jono Mingard

Bug Description

The same paginator should be used wherever possible. For Mahara 1.5 a new algorithm was used to produce the steps in the paginator, e.g. for /admin/users/search.php

For example on /group/members.php the old paginator is still used.

This should be unified to the new paginator wherever a paginator appears.

Actually, most paginators on the site (including group/members.php) are already using the same function for pagination, so if you feel there should be more steps on group/members.php, or any other page, it's just a default that can easily be increased.

One exception to this is admin/users/search.php, which uses the same build_pagination() function to generate its html, but it has its own javascript, and a selector for the number of results per page. Adding that limit selector into the general pagination code is bug #803180

With "limit selector", do you mean the "Results per page..."?

If it is already the same paginator, then increasing the default setting would probably be the way to go. In another install where I also have many users in a group, I see more than just the standard 2 pages for more than 100 users in a group.

> With "limit selector", do you mean the "Results per page..."?

Yep, most of those pages already take a parameter called 'limit', so if you put something like this:

 <wwwroot>/group/members.php?id=<group-id>&limit=20

into your browser, you'll already be able to see 20 results per page instead of the default 10. What's missing is a way to select the limit (also, the limit probably won't 'stick' after searching).

Changed in mahara:
status: New → Triaged
importance: Undecided → Low
milestone: none → 1.6.0
Melissa Draper (melissa) on 2012-09-05
Changed in mahara:
milestone: 1.6.0 → 1.7.0
Aaron Wells (u-aaronw) on 2013-04-19
Changed in mahara:
milestone: 1.7.0 → 1.8.0
Aaron Wells (u-aaronw) on 2013-09-30
Changed in mahara:
milestone: 1.8rc1 → 1.8.0
Aaron Wells (u-aaronw) on 2013-10-03
Changed in mahara:
milestone: 1.8.0 → 1.9.0
Jono Mingard (mingard) on 2014-02-18
Changed in mahara:
assignee: nobody → Jono Mingard (mingard)

Reviewed: https://reviews.mahara.org/3020
Committed: http://gitorious.org/mahara/mahara/commit/7f47927b475e7a22f18b0f3cc6a189c65ada624b
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 7f47927b475e7a22f18b0f3cc6a189c65ada624b
Author: Jono Mingard <email address hidden>
Date: Wed Feb 19 09:52:57 2014 +1300

Use standard paginator when searching for users (Bug #995761)

- Changed the "User search" page to use paginator.js rather than a custom
file and made paginator.js extendable enough that User search can still
have sorting, advanced queries, etc.
- Rewrote adminusersearch.js in jQuery
- Allow setting max results in "Find friends"

Change-Id: I0046351b87fc7e01a314c1194a842cf70dda0e4e
Signed-off-by: Jono Mingard <email address hidden>

Robert Lyon (robertl-9) on 2014-03-05
Changed in mahara:
status: Triaged → Fix Committed

Reviewed: https://reviews.mahara.org/3100
Committed: http://gitorious.org/mahara/mahara/commit/974c12c0f65b69950859c09177fbae9673c846ca
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 974c12c0f65b69950859c09177fbae9673c846ca
Author: Son Nguyen <email address hidden>
Date: Mon Mar 17 09:01:11 2014 +1300

Fix clicking 'All' and 'None' links in user search page (Bug #1292303)

This is a regression see Bug #995761
Also replace the use of Mochikit $() to jQuery $j()

Change-Id: I7998105ed8f838c6c6d2f6582246f723db95cbc7
Signed-off-by: Son Nguyen <email address hidden>

Robert Lyon (robertl-9) on 2014-04-22
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Duplicates of this bug

Other bug subscribers