Mahara

Sitemap download page is not public

Bug #979538 reported by Richard Mansfield on 2012-04-12
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
​ Mahara
Fix Released
Medium
Richard Mansfield
Mahara 1.5.1
Also affects project (?) Also affects distribution/package Nominate for series

Bug Description

In commit 647a99fd1025ceb748f8455b82418b03d788f9a8 (see bug #914490), the sitemaps were made available from the download.php script, but this script is not publicly accessible, so crawlers would not be able to download them.

Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/1156
Committed: http://gitorious.org/mahara/mahara/commit/72ed0b00206c1f060b442f107694961c7b74d8f7
Submitter: Hugh Davenport (<email address hidden>)
Branch: master

commit 72ed0b00206c1f060b442f107694961c7b74d8f7
Author: Richard Mansfield <email address hidden>
Date: Thu Apr 12 16:00:30 2012 +1200

    Make download.php publicly accessible (bug #979538)

    In commit 647a99fd1025ceb748f8455b82418b03d788f9a8 (see bug #914490),
    the sitemaps were made available from the download.php script, but
    this script is not publicly accessible, so crawlers would not be able
    to download them.

    Making the script public is okay here, because whenever a non-sitemap
    file is requested, there is already an exception thrown if the user is
    not logged in.

    Change-Id: Ia9c62940ee7dada05f4f1b448ead0c146171535c
    Signed-off-by: Richard Mansfield <email address hidden>

Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/1155
Committed: http://gitorious.org/mahara/mahara/commit/e6bdf9dc45b3bfb93baa7bb2dc5b1a904510f4d7
Submitter: Hugh Davenport (<email address hidden>)
Branch: 1.5_STABLE

commit e6bdf9dc45b3bfb93baa7bb2dc5b1a904510f4d7
Author: Richard Mansfield <email address hidden>
Date: Thu Apr 12 16:00:30 2012 +1200

    Make download.php publicly accessible (bug #979538)

    In commit 647a99fd1025ceb748f8455b82418b03d788f9a8 (see bug #914490),
    the sitemaps were made available from the download.php script, but
    this script is not publicly accessible, so crawlers would not be able
    to download them.

    Making the script public is okay here, because whenever a non-sitemap
    file is requested, there is already an exception thrown if the user is
    not logged in.

    Change-Id: Ia9c62940ee7dada05f4f1b448ead0c146171535c
    Signed-off-by: Richard Mansfield <email address hidden>

Richard Mansfield (richard-mansfield) on 2012-04-20
Changed in mahara:
status: In Progress → Fix Committed
Melissa Draper (melissa) on 2012-05-07
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.
Subscribing...

Other bug subscribers