Blocks showing if no relevant information to shared user

[William Mair]

As per the attached image, block headers show on a shared page even if the person viewing the page does not have access to view the information within the block.

An example would be if person X is in groups 2, 3 and 4 and person Y is in groups 2 and 3. If person X adds the Recent Forum Posts for group 4 and shares the page with person Y, the block shows, but as the person does not have access to view the group forum posts, no information shows within the block.

I'd say that it would look better if the block did not show at all, or if it included a message to say that you cannot view the information within this block.

Thanks

[William Mair (wmair)]

As an addition, I've added a screenshot of how this would look for users within the groups

[Kristina Hoeppner (kris-hoeppner)]

Hi William,

The second screenshot you added shows all the posts that person X has access to, right? Person Y would not see them but a message saying "You can't see these posts" or no block at all.

Do you plan on working on this? I could assign you to this bug.

Cheers
Kristina

[William Mair (wmair)]

Kristina,

I think that the problem may lie deeper than just in these blocks and in all blocks created with no content.

I've had a little dig around and I'd guess that a check of the block content in the build_column function of /lib/view.php would solve this.

I can have a go at the bug fix if you like, but I've done any before (I suppose I'll probably have to start somewhere), so may need help further down the line if I can get the code fixed.

I'll post a question to the forum asking for feedback on whether they'd prefer to see no block or a message saying "You do not have permission to view the content of this post or none has been added" (or something like that).

Thanks

[William Mair (wmair)]

Kristina,

I've had a bit of a look around files and my plugin file and coupled with the second part of feedback from Andrew Nicols here (http://mahara.org/interaction/forum/topic.php?id=4282), I think that it should be the .tpl files for each block/artefact that the text change should be in it.

For example in GoogleApps (as in the 3rd image I posted in the link above), I can put an 'x' in the embed code, which will give an empty block, but the content itself is not actually empty.

It's strange in a way, because I'm not sure if it's really a bug after all (at least not as far as I can see for the core code), but looks bad if the blocks are not checking for it.

I hope that makes sense.

Thanks

[Kristina Hoeppner (kris-hoeppner)]

Hi William,

Sorry, but I can't help with where to hunt down this message, but a developer might have an idea. Let us know if you want to work on improving this and one of us will assign you to this.

Did you have a poke around at https://wiki.mahara.org/index.php/Developer_Area/Contributing_Code and https://wiki.mahara.org/index.php/Developer_Area/Developer_Environment ? There's some good information about how to contribute code and getting started with the review system.

If you want more immediate advice, you can also jump onto the IRC dev channel #mahara-dev.

[William Mair (wmair)]

Kristina,

It looks like the wordings actually need to be on the plugins rather than the core code, so I'd say that this can be closed as there's not really a bug.

Thanks

[François Marier (fmarier)]

Closing this bug as suggested by William.