Blog block pagination bug prevents images from being displayed

Bug #886581 reported by Iñaki Arenaza on 2011-11-05
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Medium
Iñaki Arenaza

Bug Description

As the viewid is not added to the URL for the images, images are considered not published and we don't have permission to see them. In fact, if we right click on the image place holder and click on 'Display image' (or equivalent browser option), we are presented with a login screen, even if we are logged in.

Just make sure the viewid is passed to ArtefactTypeBlogpost::get_posts() too as part of the configdata, to include it in the image access URL.

This bug is present in 1.4 and master (and 1.3 too, but that's out of supprt)

1.3 is still supported right now. :-)

Reviewed: https://reviews.mahara.org/831
Committed: http://gitorious.org/mahara/mahara/commit/ff849221e83de315685cc79f212c5488e45d3e45
Submitter: Richard Mansfield (<email address hidden>)
Branch: master

commit ff849221e83de315685cc79f212c5488e45d3e45
Author: I��aki Arenaza <email address hidden>
Date: Sat Oct 29 20:29:03 2011 +0200

    Blog block pagination bug prevents images from being displayed

    Bug #886581

    As the viewid is not added to the URL for the images, images are
    considered not published and we don't have permission to see them.
    In fact, if we right click on the image place holder and click
    on 'Display image' (or equivalent browser option), we are presented
    with a login screen, even if we are logged in.

    Just make sure the viewid is passed to ArtefactTypeBlogpost::get_posts()
    too as part of the configdata, to include it in the image access URL.

    Change-Id: I23138180fbd771755407c39a9669860e4ecef762
    Signed-off-by: I��aki Arenaza <email address hidden>

Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/830
Committed: http://gitorious.org/mahara/mahara/commit/8154cf5c3a250a1cd600bda5bb4a82e3e089fe3a
Submitter: Richard Mansfield (<email address hidden>)
Branch: 1.4_STABLE

commit 8154cf5c3a250a1cd600bda5bb4a82e3e089fe3a
Author: I��aki Arenaza <email address hidden>
Date: Sat Oct 29 20:29:03 2011 +0200

    Blog block pagination bug prevents images from being displayed

    Bug #886581

    As the viewid is not added to the URL for the images, images are
    considered not published and we don't have permission to see them.
    In fact, if we right click on the image place holder and click
    on 'Display image' (or equivalent browser option), we are presented
    with a login screen, even if we are logged in.

    Just make sure the viewid is passed to ArtefactTypeBlogpost::get_posts()
    too as part of the configdata, to include it in the image access URL.

    Change-Id: Id89be470f4fbb927984624d8a2b7a55629b50016
    Signed-off-by: I��aki Arenaza <email address hidden>

Changed in mahara:
status: New → Fix Committed
assignee: nobody → Iñaki Arenaza (iarenaza)
milestone: none → 1.4.2
François Marier (fmarier) wrote :

I just want to note that while 1.3 is still supported, that's for security-related issues only.

Bug fixes go onto 1.4 only at this stage.

Melissa Draper (melissa) on 2012-03-06
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers