Mahara

The AJAX login box doesn't look good

Bug #885520 reported by Hugh Davenport
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Triaged
Low
Unassigned

Bug Description

The AJAX login box (which appears when the session times out when doing javascripty things) doesn't look very good.

I propose fixing it so that it looks neater. It could be based of the login sidebar, which is already themed.

Hugh Davenport (hugh-davenport)
Changed in mahara:
status: New → In Progress
importance: Undecided → Wishlist
assignee: nobody → Hugh Davenport (hugh-catalyst)
milestone: none → 1.5.0
François Marier (fmarier)
Changed in mahara:
importance: Wishlist → Low
Revision history for this message
François Marier (fmarier) wrote :

https://reviews.mahara.org/#change,825

Revision history for this message
Ruslan Kabalin (rkabalin) wrote :

Just think it would be better if the content for ajax login box will be fetched by ajax request (since it is AJAX login box :)) ) from php script, which would in turn generate the form the same way as it is produced for sideblock (e.g. sideblocks/login.tpl along with auth_generate_login_form()).

It is a bit ugly to have that much plain code in javascript file - replacing that with DOM definitions could look better, but since is mostly duplicates the form we have in the code already, why not using that.

Revision history for this message
François Marier (fmarier) wrote :

Also see: https://reviews.mahara.org/#change,833

Changed in mahara:
milestone: 1.5.0 → none
status: In Progress → Triaged
assignee: Hugh Davenport (hugh-catalyst) → nobody
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.