Youtube embed links with dashes or underscores do not work

Bug #884438 reported by Christopher Tombleson on 2011-10-31
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Mahara
Medium
Christopher Tombleson

Bug Description

The YouTube custom html filter will not parse YouTube embed tags with dashes in them.

For example this embed code will not be parsed: <iframe width="1280" height="720" src="http://www.youtube.com/embed/3ciFi-1YYdM" frameborder="0" allowfullscreen></iframe>

Changed in mahara:
assignee: nobody → Christopher Tombleson (christopher-k)
status: New → In Progress
Changed in mahara:
importance: Undecided → Medium
status: In Progress → Triaged
status: Triaged → In Progress
Changed in mahara:
milestone: none → 1.4.2

Reviewed: https://reviews.mahara.org/814
Committed: http://gitorious.org/mahara/mahara/commit/7db9b13dced5f51a8ab1e726cc57613b5ec6a10a
Submitter: Richard Mansfield (<email address hidden>)
Branch: master

commit 7db9b13dced5f51a8ab1e726cc57613b5ec6a10a
Author: Christopher Tombleson <email address hidden>
Date: Tue Nov 8 09:13:38 2011 +1300

    Fixed Youtube html filter.

    The html filter will now parse links with dashes in them.
    Also will now parse links with parameters in them.

    Bug #882499
    Bug #884438

    Change-Id: I96c17381e67488bb2b2eefc4106474b454fa40fd
    Signed-off-by: Christopher Tombleson <email address hidden>

Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/863
Committed: http://gitorious.org/mahara/mahara/commit/91b7ec13bd1baf416ea66d466b634593d5178044
Submitter: Hugh Davenport (<email address hidden>)
Branch: master

commit 91b7ec13bd1baf416ea66d466b634593d5178044
Author: Christopher Tombleson <email address hidden>
Date: Wed Nov 16 10:31:50 2011 +1300

    Fixed Youtube html filter.

    The html filter will now parse links with underscores in them.

    Bug #884438

    Change-Id: I117b3162b44ecb372d42454c0d64224d01f363b7
    Signed-off-by: Christopher Tombleson <email address hidden>

summary: - Youtube embed links with dashes in them do not work
+ Youtube embed links with dashes or underscores do not work
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/839
Committed: http://gitorious.org/mahara/mahara/commit/4c7e59f48a2a8da0b40cf3f811c0e12ed7fc3be7
Submitter: Francois Marier (<email address hidden>)
Branch: 1.4_STABLE

commit 4c7e59f48a2a8da0b40cf3f811c0e12ed7fc3be7
Author: Christopher Tombleson <email address hidden>
Date: Fri Nov 11 10:45:33 2011 +1300

    Fixed Youtube html filter.

    The html filter will now parse links with dashes and underscores in them.
    Also will now parse links with parameters in them.
    Also will now parse links that use https.

    Bug #884438

    Change-Id: I2375018af717f1384339937606040442fdf60455
    Signed-off-by: Christopher Tombleson <email address hidden>
    Signed-off-by: Francois Marier <email address hidden>

Changed in mahara:
status: In Progress → Fix Committed
Melissa Draper (melissa) on 2012-03-06
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Duplicates of this bug

Other bug subscribers