Change pseudo-headers of forum emails

[François Marier]

Forum emails currently start with two lines that repeat information that's already available elsewhere in the email:

- forum topic
- date
- author

I propose that we remove this duplicated information and instead replace it with a single line that contains (in bold):

- group name
- forum name

This extra line will probably be useful once we shorten the subject line (see bug #882891)

[Kristina Hoeppner (kris-hoeppner)]

This extra line should be in the email, I think, so that it is easy to determine to which forum and group the mail belongs without having to look up the extended header which most people will not know about.

[François Marier (fmarier)]

Yeah that's exactly what I had in mind. A "pseudo-header" is one that's in the body of the email as opposed to hidden inside the headers.

[François Marier (fmarier)]

https://reviews.mahara.org/#change,846

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/846
Committed: http://gitorious.org/mahara/mahara/commit/93c012f2e1f6dd61564a860cf74ae92a237ca7ce
Submitter: Francois Marier (<email address hidden>)
Branch: master

commit 93c012f2e1f6dd61564a860cf74ae92a237ca7ce
Author: Melissa Draper <email address hidden>
Date: Fri Nov 11 16:01:29 2011 +1300

    Add pseudoheaders to forums mail messages (bug 882894)

    We removed info from the email subject and added it to headers. However
    people generally don't see the headers, so this patch adds the info back
    as pseudoheaders, while removing duplicate info such as poster name,
    topic and time.

    Change-Id: I1063c70693e3b6345d41225b8fed53e0c20e7d95
    Signed-off-by: Melissa Draper <email address hidden>

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/1036
Committed: http://gitorious.org/mahara/mahara/commit/1c022eed9e695f639f49c35ece191ddda1a6cb05
Submitter: Francois Marier (<email address hidden>)
Branch: master

commit 1c022eed9e695f639f49c35ece191ddda1a6cb05
Author: Richard Mansfield <email address hidden>
Date: Fri Feb 3 11:40:34 2012 +1300

    Remove unnecessary sanitisation from forum notifications (bug #882894)

    In commit 93c012f2e1f, the forum and group name were added to the body
    of forum post email notifications, each wrapped in a call to
    clean_html (htmlpurifier). This crashes cron due to out-of-memory
    errors whenever there are more than a few subscribers, and stops
    notifications from being sent out at all.

    The forum and group name only need to be rendered once per forum post,
    so this could be fixed by moving the clean_html call up to the
    activity constructor, rather than doing it in the get_emailmessage,
    get_htmlmessage functions. These functions get called for every
    single subscriber notification, to ensure the string is displayed in
    the subscriber's language.

    But because group and forum names are never rendered as html, we don't
    need to use htmlpurifier - html escaping is more appropriate and less
    memory-hungry.

    Change-Id: I0a4133b0a11e0e0004bdab1c29984ab4fc5dfbbf
    Signed-off-by: Richard Mansfield <email address hidden>