get_all_theme_objects and directory starts with dot

Reported by Yaju Mahida on 2011-10-06
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Wishlist
Andrew Nicols

Bug Description

We use subversion and under each sub-directory of Mahara a directory called .svn is created by it.

The logic in the function get_all_theme_objects and $subdir != "." && $subdir != ".." doesn't skip .svn directory which generates [WAR] 09 (lib/mahara.php:639) The name of the theme '.svn' contains invalid characters.

I have modified the logic as if (substr($subdir, 0, 1) != "." && is_dir($themebase . $subdir)) which solves the issue - ignores all directories with dot and double dots.

Yaju Mahida (yvm) wrote :

Patch added without hard tabs and comments

Changed in mahara:
milestone: none → 1.5.0
assignee: nobody → Andrew Nicols (dobedobedoh)
status: New → Triaged
status: Triaged → In Progress
importance: Undecided → Low
importance: Low → Wishlist

Reviewed: https://reviews.mahara.org/784
Committed: http://gitorious.org/mahara/mahara/commit/b4afc8912bd31250997d6396da6fb33ec95a7a5b
Submitter: Francois Marier (<email address hidden>)
Branch: master

commit b4afc8912bd31250997d6396da6fb33ec95a7a5b
Author: Andrew Robert Nicols <email address hidden>
Date: Sun Oct 9 23:34:11 2011 +0100

    Ignore hidden theme directories (bug #868851)

    Change-Id: I2aaf8068fac96725caee93e01b787f13ff8585eb
    Signed-off-by: Andrew Robert Nicols <email address hidden>

Changed in mahara:
status: In Progress → Fix Committed
Melissa Draper (melissa) wrote :

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

 status fixreleased
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEcBAEBAgAGBQJPjrYkAAoJECXBtiziiXdcBjUH+gOs1qGQ20HFISw5maAWKxaU
yT4JUSRYzcVk8g5FgnONKIDVMKo9ZiyZD0xTWoevwRamE5IiE00ltsoxtaVecvBx
Km/hOBIiaTCfNlZ/nCULO+FUflYWhuzjb8szGQNCLTJLXzHq1Q/BRJAWPzKvUweo
zKe23pNiXtMlRkqEs+IwWnf04M3YH8O6tqcoirtLWPmLRJxtW19qT5LOGdkFojVP
ode3BhogyPMFWxS9mhn0AgE9j/GdNMXbPxKCSqLhrcDCQvC+wXNqvWC/Fp7jMe0n
5mPXBmBPLCiQAIQ7a9GNV/71GhLEB6YkZ1HZj+EkCuXvdejKe/MutEVgHIiZUus=
=Yjja
-----END PGP SIGNATURE-----

Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers