Profile page DB title is not overwritten

Bug #860154 reported by Kristina Hoeppner
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Low
Richard Mansfield

Bug Description

Profile page is called "Profile view" in Access list (Mahara master) -> profile page shouldn't have its DB title displayed, but it should be overwritten by the lang string like on the My Pages page

Changed in mahara:
status: New → Triaged
importance: Undecided → Low
Changed in mahara:
assignee: nobody → Richard Mansfield (richard-mansfield)
milestone: none → 1.5.0
status: Triaged → In Progress
Changed in mahara:
milestone: 1.5.0 → none
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/780
Committed: http://gitorious.org/mahara/mahara/commit/d72aeaf3bd9151faab86565db022314067cf2aff
Submitter: Richard Mansfield (<email address hidden>)
Branch: master

commit d72aeaf3bd9151faab86565db022314067cf2aff
Author: Richard Mansfield <email address hidden>
Date: Thu Oct 6 13:06:18 2011 +1300

    Remove view title display logic from my views template (bug #860154)

    As a result of profile view access changes in bug #807278, profile
    views are displayed on the share page. So the 'editing' version
    of view titles needs to be displayed in two places (my views/
    group views etc., and on the share page). It makes sense to use
    the same View methods in both cases, and remove the old logic to
    get the view title and url from the template.

    Change-Id: Ifa36651dc3358acd71ca63407df79799ddd47299
    Signed-off-by: Richard Mansfield <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/779
Committed: http://gitorious.org/mahara/mahara/commit/1661f54e0f13bf6b7aeb82ef1de504e6d429a340
Submitter: Richard Mansfield (<email address hidden>)
Branch: master

commit 1661f54e0f13bf6b7aeb82ef1de504e6d429a340
Author: Richard Mansfield <email address hidden>
Date: Thu Oct 6 12:29:07 2011 +1300

    Overwrite the profile view title on the Share page (bug #860154)

    The profile view title is now displayed on the share page, due to
    recent changes in profile view access (see bug #807278). However
    the view title from the database is now displayed on the share page
    instead of the translatable string.

    Change-Id: Ic691469731923faa0cef0c204b1207a9152e9fe2
    Signed-off-by: Richard Mansfield <email address hidden>

Changed in mahara:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.