Sending a friend request should return you to the page you were previously on

Bug #852304 reported by Kristina Hoeppner on 2011-09-17
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Low
Robert Lyon

Bug Description

Reported by a user: "When I click on Send Friend request and then request friendship I am returned to page one of the list, not the page I was on (which might have been page 14ish).

It should return me to the page in the list I was on."

Changed in mahara:
importance: Undecided → Low
status: New → Triaged
tags: added: usability
summary: - Finishing an action should return you to the page you were previously on
+ Sending a friend request should return you to the page you were
+ previously on
Robert Lyon (robertl-9) wrote :

This was a quick change so I made a patch for it:
https://reviews.mahara.org/#/c/2708/

Changed in mahara:
status: Triaged → In Progress
assignee: nobody → Robert Lyon (robertl-9)
Changed in mahara:
milestone: none → 1.9.0
Steven (stevens-q) wrote :

===== How to test - return to same page =====

=== Prerequisites ===

1. You must have enough users to be able to generate Pagination

=== Steps ===
1. LOGGED IN as an authenticated user
2. BROWSE to find friends page located under the Groups tab.
 Note: you should see a few pages of users
3. Move to the last page of users
4. CLICK the "send friend request" button
 Note: this action will take you to a page to type a message
5. TYPE in a message or just CLICK the "Request friendship" button
6. CONFIRM that the user is taken back to the previous page (last page of users)

===== Test Results =====
6. CONFIRM that the user is taken back to the previous page (last page of users) ✔

Catalyst QA Approved ✔

Reviewed: https://reviews.mahara.org/2708
Committed: http://gitorious.org/mahara/mahara/commit/77dd66aa380cd60ad4bb08fdbcc8a2a84878b2ca
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 77dd66aa380cd60ad4bb08fdbcc8a2a84878b2ca
Author: Robert Lyon <email address hidden>
Date: Thu Nov 14 13:50:30 2013 +1300

Friend request options return you to correct pagination (bug #852304)

- have got the deny request, remove friend, send message and request
friend options remembering the pagination

- I also altered the code in some places to match the coding layout
in others.

The offset variable gets passed through to form so on return you end
up on correct pagination page rather than beginning of list

Change-Id: I043240f2be97431b2db2376999ec551569a37e82
Signed-off-by: Robert Lyon <email address hidden>

Robert Lyon (robertl-9) on 2013-12-23
Changed in mahara:
status: In Progress → Fix Committed
Robert Lyon (robertl-9) on 2014-04-22
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers