Date of Birth time field on resume not translatable

Bug #824638 reported by Andrew Nicols
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Melissa Draper

Bug Description

In artefact/resume/index.php the following is defined for the format of the dateofbirth:
'ifFormat' => '%Y/%m/%d'

Ideally, we need to convert thing to a get_string('strfYMD', 'langconfig') etc with appropriate name.
Not sure whether this has any consequences, though I think pieforms should handle these.

Any thoughts?

Revision history for this message
Andrew Nicols (dobedobedoh) wrote :

I'm putting the target to 1.4.1 for the moment as it is a bug which makes life harder for users of other languages

Changed in mahara:
status: New → Incomplete
status: Incomplete → Confirmed
importance: Undecided → Medium
milestone: none → 1.4.1
Revision history for this message
Richard Mansfield (richard-mansfield) wrote :

Andrew, I'm not sure whether it'll just work, you'll have to try it and see if you need to do a bit of messing around with strptime like on the view access page, which uses get_string('strftimedatetimeshort'). Might not be a big deal with the date of birth because you never need to compare times, it's just making sure the input format is converted to the db format accurately.

Revision history for this message
Melissa Draper (melissa) wrote :

There are also further notes on this at https://reviews.mahara.org/#change,729

Revision history for this message
Melissa Draper (melissa) wrote :

I've spent most of today arguing with this issue and trying to find a way to do this change in a pointrelease-friendly way.

My best suggestion is to change it to a date type field rather than calendar type.

Revision history for this message
François Marier (fmarier) wrote :

Well, maybe it's not important enough for a point release.

As far as I can tell, it's not a regression. While it's certainly a pain point for lots of users, it's not any worse than previous versions of Mahara. We should fix it properly in 1.5.

Changed in mahara:
milestone: 1.4.1 → 1.5.0
Changed in mahara:
status: Confirmed → In Progress
assignee: nobody → Melissa Draper (melissa)
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/729
Committed: http://gitorious.org/mahara/mahara/commit/52504d9580583204642c0ec39fa9e4a7060a8f02
Submitter: Francois Marier (<email address hidden>)
Branch: master

commit 52504d9580583204642c0ec39fa9e4a7060a8f02
Author: Melissa Draper <email address hidden>
Date: Thu Sep 22 17:18:34 2011 +1200

    Make DoB configurable via get_string (bug #824638)

    Add get_string support for the DoB field and descriptions. The
    strings are strfdateofbirth for the date, and dateofbirthformatguide
    for the description.

    Change-Id: I2a5eb8cc7c17bff3a4298bc9776a7439fc4bd1f7
    Signed-off-by: Melissa Draper <email address hidden>

Changed in mahara:
status: In Progress → Fix Committed
Melissa Draper (melissa)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.