Edit and Select buttons not working for some embed types in some browsers

[shanen]

The buttons (e.g. Edit/Select) for the "Some HTML" "An Image" and "Embedded Media" embeddable media types when creating a portfolio page don't work under Google Chrome 12 (latest), Safari 5 (maybe more). They work in Firefox 5.
This is for Mahara 1.4.0.
Suspect Webkit specific JS and CSS is causing trouble, webkit is 100% ACID 3 compliant.

[Kristina Hoeppner (kris-hoeppner)]

I can confirm this for master using "Files to Download": There the Edit and Select buttons don't do anything whereas the buttons work fine in the image gallery block.

[Kristina Hoeppner (kris-hoeppner)]

I used Chromium 12 on Ubuntu and Chrome 12 on Mac.

[Hugh Davenport (hugh-davenport)]

problem seems to be only when selecting files, when folder selector is on (ie, A Folder or Image Gallery (folder option) blocktypes work), while all the filebrowser like blocktypes don't work
Can't reproduce on my master copy, will do a pull and see if that changes anything.
Reproduced on myportfolio

[Hugh Davenport (hugh-davenport)]

Just another note, the upload new file button doesn't work either in these blocktypes

[Kristina Hoeppner (kris-hoeppner)]

Sorry, I wrote "master" instead of "myportfolio" (master+some customizations) above. I haven't been able to reproduce it on my fresh local master copy and Mahara 1.4 in Chromium.

MyPortfolio selection of "Edit" or "Select" doesn't work on my Safari 5.1 either.

[Kristina Hoeppner (kris-hoeppner)]

Hugh tracked the issue down to being a problem with the latest Chrome browser. It worked before. Disabling the copyright acceptance notice (Extensions -> Plugin type: Artefact -> File Config) solves the problem temporarily. Unfortunately, no real fix has yet been discovered.

[François Marier (fmarier)]

Until someone is able to dig into this one further, it doesn't look like we can easily fix it...

[Launchpad Janitor (janitor)]

[Expired for Mahara because there has been no activity for 60 days.]

[Don Presant (don-learningagents)]

This bug expired, but I hope it can be renewed...I`m trying to use a Chrome browser to embed an image block and it doesn`t work.

Chrome is becoming a very popular browser (more downloads than FF these days) and I don`t think disabling copyright acceptance is a sustainable solution...any new thoughts on this?

[François Marier (fmarier)]

https://reviews.mahara.org/#change,1050

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/1050
Committed: http://gitorious.org/mahara/mahara/commit/56ace97c3e24158e8cf39a883a0e52c717e3a8a5
Submitter: Francois Marier (<email address hidden>)
Branch: master

commit 56ace97c3e24158e8cf39a883a0e52c717e3a8a5
Author: Richard Mansfield <email address hidden>
Date: Wed Feb 15 15:22:13 2012 +1300

    Fix file block config edit, select, upload buttons in Chrome (bug #819102)

    For filebrowsers inside configuration forms in Chrome, the edit,
    select, and file upload buttons appear to have no effect when the
    copyright agreement is enabled.

    In fact the javascript for these buttons *is* executed, but Chrome
    won't display the resulting changes, making it rather difficult to
    click on some of the buttons in forms that are opened up.

    Adding a slight delay before disabling the file input fixes the issue.

    Change-Id: I8cfde0056f0aefc027e3a532488be3c369292b65
    Signed-off-by: Richard Mansfield <email address hidden>