Some overridden fields are not disabled in admin/site/options.php

Reported by Andrew Nicols on 2011-06-30
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Low
Andrew Nicols

Bug Description

Some of the fields in admin/site/options.php don't have the disabled => in_array('foo', $OVERRIDDEN) option set

Have patch, will submit

Affects 1.4.x and master

François Marier (fmarier) wrote :

Andrew, are these settings correctly ignored (i.e. it's a cosmetic problem) or is it possible to cheat and change overriden settings?

Reviewed: https://reviews.mahara.org/421
Committed: http://gitorious.org/mahara/mahara/commit/464c9b91c7a7d7ec3d65f05b29b90db3b0fc1b0c
Submitter: Francois Marier (<email address hidden>)
Branch: master

commit 464c9b91c7a7d7ec3d65f05b29b90db3b0fc1b0c
Author: Andrew Robert Nicols <email address hidden>
Date: Thu Jun 30 16:27:54 2011 +0100

    Ensure that all fields in admin/site/options.php are disabled if overridden (bug #803962)

    Change-Id: Iecdbb28023dff83a897e53f6058d6e1136cf5c6b
    Signed-off-by: Andrew Robert Nicols <email address hidden>

Changed in mahara:
milestone: 1.4.1 → 1.5.0
status: In Progress → Fix Committed
Melissa Draper (melissa) on 2012-04-18
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers