Overridden site admin fields not disabled unless also stored in database
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Mahara |
Fix Released
|
Low
|
Andrew Nicols |
Bug Description
If you explicitly set a field in config.php, then it /should/ be disabled in admin/site/
This currently only happens if that setting is also stored in the database.
As a result, users believe that they can change the option, but when they then try to, the option is unset, the field greyed out, and there is no message informing them that they can't change the setting.
This appears to stem from the way that the $OVERRIDDEN variable is filled in lib/mahara.
At present, this grabs all config options set in the database.
For any option in the database, it then checks for an override, and if it's already present in $CFG, it adds this to the OVERRIDDEN array. If it isn't present in $CFG already, it adds it to $CFG so that it's accessible.
Have a patch to submit for this.
Affects 1.4.x and master
Changed in mahara: | |
status: | In Progress → Fix Committed |
Changed in mahara: | |
status: | Fix Committed → Fix Released |
Submitted fix in https:/ /reviews. mahara. org/#change, 420