Do not display the username to a person registering for an account

[Kristina Hoeppner]

The account denial email (master) in htdocs/auth/internal/lang/en.utf8/auth.internal.php shows the username after the name of the administrator. That should not happen.

Accound denial email:
As this is an email that looks like it's bein sent from a direct user, it's weird that it is more impersonal than the other.

Hi Name,

Your registration attempt at Mahara has been denied.

Reason:

"No students accepted"

--
Regards,
Kristina Hoeppner (kristina)

-------------------------------------------

Note: Some of the wording may differ when you look at the text depending on whether the change for bug #803733 was accepted.

[François Marier (fmarier)]

This is due to the display_name() function including the username of a person when it's run as admin.

[Robert Lyon (robertl-9)]

The display_name() function can take a $nameonly variable

So maybe we could go display_name($USER, null, true) and then change the display_name function's line from

$addusername = $username || !empty($userto->admin) || !empty($userto->staff);

to

$addusername = $username || (!empty($userto->admin) && $nameonly == false) || (!empty($userto->staff) && $nameonly == false);

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/12039

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/12039
Committed: https://git.mahara.org/mahara/mahara/commit/c9b221692938a3cbd357dbe06e32e5b3aa357a7d
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit c9b221692938a3cbd357dbe06e32e5b3aa357a7d
Author: Dianne Tennent <email address hidden>
Date: Tue Sep 28 09:52:59 2021 +1300

Bug 803747: Remove username from denial email

When user receives denial of registration email
message, no longer has username in brackets, just
the sender's full name.

Change-Id: I427885128ee699eac50ca06a93709ce6dbe256b7