"copy this page" in group is linked incorrectly

Bug #800373 reported by Kristina Hoeppner
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
High
Hugh Davenport

Bug Description

Mahara 1.4 stable; tested on demo.mahara.org

http://mahara.org/interaction/forum/topic.php?id=3766

When a group page is made copyable, the "Copy this page" link appears next to it when group pages are shown on the group homepage. However, the link points to the group homepage itself.

Tags: group
Changed in mahara:
milestone: none → 1.4.1
Changed in mahara:
assignee: nobody → Hugh Davenport (hugh-catalyst)
Revision history for this message
Hugh Davenport (hugh-davenport) wrote :
Changed in mahara:
status: Confirmed → In Progress
Revision history for this message
Hugh Davenport (hugh-davenport) wrote :
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/429
Committed: http://gitorious.org/mahara/mahara/commit/dd9395a450cef9789147125833247b9499fde047
Submitter: Richard Mansfield (<email address hidden>)
Branch: 1.4_STABLE

commit dd9395a450cef9789147125833247b9499fde047
Author: Hugh Davenport <email address hidden>
Date: Mon Jul 4 15:06:34 2011 +1200

    Fix group views blocktype copy page feature

    Before, the copy page button linked back to group homepage
    instead of copying the page.

    This fix changes the button to be a form as in /view/choosetemplate.php

    The copied page is placed into the group just like /view/choosetemplate.php
    does when inside a group

    Bug #800373

    Change-Id: I81e94fde8e0dab12bd06c1018b6171a74d6cbe38
    Signed-off-by: Hugh Davenport <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/428
Committed: http://gitorious.org/mahara/mahara/commit/118084a6a6c609e54471b55b22db48b7d76a9c50
Submitter: Hugh Davenport (<email address hidden>)
Branch: master

commit 118084a6a6c609e54471b55b22db48b7d76a9c50
Author: Hugh Davenport <email address hidden>
Date: Mon Jul 4 15:06:34 2011 +1200

    Fix group views blocktype copy page feature

    Before, the copy page button linked back to group homepage
    instead of copying the page.

    This fix changes the button to be a form as in /view/choosetemplate.php

    The copied page is placed into the group just like /view/choosetemplate.php
    does when inside a group

    Bug #800373

    Change-Id: I81e94fde8e0dab12bd06c1018b6171a74d6cbe38
    Signed-off-by: Hugh Davenport <email address hidden>

Changed in mahara:
status: In Progress → Fix Committed
Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/672
Committed: http://gitorious.org/mahara/mahara/commit/b730b9e9301e4c043d0820eaaa557c1afc5105ba
Submitter: Hugh Davenport (<email address hidden>)
Branch: master

commit b730b9e9301e4c043d0820eaaa557c1afc5105ba
Author: Hugh Davenport <email address hidden>
Date: Fri Sep 9 13:43:56 2011 +1200

    Fix group view blocktype copy page feature.

    This was introduced in commit 118084a6a6c609e54471b55b22db48b7d76a9c50

    The original code presumed that the the data was an object, but was infact
    an array. This patch changes it to array access's instead of object deref's.

    Bug #800373

    Change-Id: I4a70eef6c5fec9c1cf8174f78a96e31df29bfd4f
    Signed-off-by: Hugh Davenport <email address hidden>

Revision history for this message
François Marier (fmarier) wrote :
Changed in mahara:
status: Fix Committed → In Progress
Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/684
Committed: http://gitorious.org/mahara/mahara/commit/d2702455eeb501d15f51531e37b7d5a50e8e6cee
Submitter: Francois Marier (<email address hidden>)
Branch: 1.4_STABLE

commit d2702455eeb501d15f51531e37b7d5a50e8e6cee
Author: Hugh Davenport <email address hidden>
Date: Fri Sep 9 13:43:56 2011 +1200

    Fix group view blocktype copy page feature.

    This was introduced in commit dd9395a450cef9789147125833247b9499fde047

    The original code presumed that the the data was an object, but was infact
    an array. This patch changes it to array access's instead of object deref's.

    Bug #800373

    Change-Id: I4a70eef6c5fec9c1cf8174f78a96e31df29bfd4f
    Signed-off-by: Hugh Davenport <email address hidden>

Changed in mahara:
status: In Progress → Fix Committed
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.