View comments pagination misbehaviour in Chrome

[Ruslan Kabalin]

The pagination of view comments does not work well in Chrome. In particular when you move backwards, the required page button is only be highlighted on the second click (on the first click the page is being changed, but pagination navigation buttons remain in the same state). This is not applicable to other pages with pagination such as group search.

Steps to reproduce:
1. Open the view with more than one page.
2. Navigate to second page (it should work as expected)
3. Navigate back to the first page (the first page will be loaded, but navigation will display the second page)
4. Navigate back to the first page again (now the navigation will change, the page will remain the same).

This is on master and 1.4_STABLE, chrome version 11.0.696.71

[Hugh Davenport (hugh-davenport)]

Hi Ruslan,

I can't reproduce this on chrome 12.0.742.91 (87961) Ubuntu 11.04 on master or 1.4_STABLE

Would you be able to post a screenshot of this. I will try at some point with earlier version of chrome.

Cheers,

Hugh

[Hugh Davenport (hugh-davenport)]

When bug #800575 is fixed, this issue happens for me on master in the journals page.

Cheers,

Hugh

[Hugh Davenport (hugh-davenport)]

Also happens on 1.4_STABLE

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/374
Committed: http://gitorious.org/mahara/mahara/commit/9459ace680939ab7b54f93a316739396d5675b39
Submitter: Francois Marier (<email address hidden>)
Branch: 1.4_STABLE

commit 9459ace680939ab7b54f93a316739396d5675b39
Author: Hugh Davenport <email address hidden>
Date: Thu Jun 23 10:03:22 2011 +1200

    Fix bug with pagination on journals page

    Bug #800575

    When pagination was used on the journals page, the user
    could not select any page other than the current. An error
    log occured if they did try.

    This fix adds a requires clause to the json script that is used
    by the pagination. Fixing this also brings up the issue in bug #795425

    Change-Id: I17516109f450e2044e4276e3f1a83dec2488bd26
    Signed-off-by: Hugh Davenport <email address hidden>

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/373
Committed: http://gitorious.org/mahara/mahara/commit/13bb52b665a25155c82e72f166512d08dca0c495
Submitter: Francois Marier (<email address hidden>)
Branch: master

commit 13bb52b665a25155c82e72f166512d08dca0c495
Author: Hugh Davenport <email address hidden>
Date: Thu Jun 23 10:03:22 2011 +1200

    Fix bug with pagination on journals page

    Bug #800575

    When pagination was used on the journals page, the user
    could not select any page other than the current. An error
    log occured if they did try.

    This fix adds a requires clause to the json script that is used
    by the pagination. Fixing this also brings up the issue in bug #795425

    Change-Id: I17516109f450e2044e4276e3f1a83dec2488bd26
    Signed-off-by: Hugh Davenport <email address hidden>