Logged out users get shown edit this page option

[Hugh Davenport]

When a logged out user visits a public site page, they get an edit this page option
When they visit a public page that was made by a user (ie not a site page), then they do NOT get the edit option

This happens with and without microheaders

I would suggest not showing the edit option for any public user.

Cheers,

Hugh

[Hugh Davenport (hugh-davenport)]

This is because the LiveUser object has id=0, and the can_edit_view function checks the owner of the view against the id (both 0)

Fix is to only check view owner against id if view owner is >0 (ie not site page, the institution check handles that

[Hugh Davenport (hugh-davenport)]

Review at https://reviews.mahara.org/117

[Hugh Davenport (hugh-davenport)]

This also affects public profiles in user/view.php

I will update patch for review

[Hugh Davenport (hugh-davenport)]

Sorry was something different I saw there, no problems with this bug