Institution authentication plugin option doesn't exist when creating new institution

[Stacey Walker]

On 1.4.0alpha2dev

When creating an institution there is no 'Authentication Plugin' configuration option available on the 'Add Institution' page. See attached addinstitution.png.

If you deselect the 'Registration allowed?' checkbox and hit submit the institution is created but the user is presented with what looks like a failed form submission. See attached authenticationpluginerror.png. A new 'Authentication Plugin' option now exists and the "Institution name" option has disappeared. There is no marker on the authentication plugin option indicating that it is required.

If you click cancel where it looks like the submission has failed you can see that the new institution was in fact created and if you edit the settings you can see that it has IMAP as the authentication plugin.

Perhaps this could be managed better with a bit of JS to tie in the registration option with the display/hide of the authentication setting; defaulting to both visible if JS is not enabled.

[Robert Lyon (robertl-9)]

Maybe we need an ok message saying institution saved to remove some of the confusion.

Ah there is already provisions set up for this - just the check is not quite correct

have added patch to fix the check
https://reviews.mahara.org/#/c/2706/

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/2706
Committed: http://gitorious.org/mahara/mahara/commit/74d25762f8cda54cecf6d164417ce4ed064daf31
Submitter: Son Nguyen (<email address hidden>)
Branch: master

commit 74d25762f8cda54cecf6d164417ce4ed064daf31
Author: Robert Lyon <email address hidden>
Date: Wed Nov 13 17:17:10 2013 +1300

show ok msg when adding instit. when reg. allowed is off (bug 746418)

there was code for this already but the check was not working

Change-Id: I40b2563d60a4b45531e3d1e5078fb37b14c22311
Signed-off-by: Robert Lyon <email address hidden>