Group members list is not displayed correctly when multiple columns are used

Bug #649626 reported by Ruslan Kabalin on 2010-09-28
16
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Mahara
Low
Hugh Davenport

Bug Description

Users block does not scale to the column size.

This is on master, FF 3.6

Ruslan Kabalin (rkabalin) wrote :
Eugene (eugenev) wrote :

Ruslan - I am unable to replicate this issue...

Has it perhaps been fixed by https://bugs.launchpad.net/mahara/+bug/648470 ?

If not, could you provide steps to reproduce?

Ruslan Kabalin (rkabalin) wrote :

Hi Eugene, the problem is still there. Steps to replicate:
1. Make sure that you have several members of the group (so that groups members block is long enough).
2. Change Group Homepage view output to 3-column one.
3. Move Members block from bottom to the left so that it is overlaid by the main About block.

Members block uses table in output rendering and the number of rows and columns is fixed - that is the reason of problem. Probably members block should have only one setting - the number of members to display, and divs could used instead of table in the output, so that the lines of items are wrapped to fit the outer block.

Changed in mahara:
status: New → Triaged
importance: Undecided → Medium
milestone: none → 1.3.3
Changed in mahara:
milestone: 1.3.3 → 1.4.0
Darryl Hamilton (lordp) on 2011-04-27
Changed in mahara:
status: Triaged → Confirmed
Changed in mahara:
importance: Medium → Low
Changed in mahara:
assignee: nobody → Hugh Davenport (hugh-catalyst)
Changed in mahara:
status: Confirmed → In Progress
Hugh Davenport (hugh-davenport) wrote :

I have submitted a patch
https://reviews.mahara.org/111

This patch changes the way the members are displayed by doing
the following:
- Replace row and column options to be the number of members
to show
- Work out how many rows and columns to display based on how
many columns in the view and how many members are being shown.

The number of rows and columns are as follows:
- 1 column layout -> 7 members per row
- 2 column layout -> 5 members per row
- 3 column layout -> 3 members per row
- 4 or 5 column layout -> 2 members per row
- new column layout options default to 1 member per row

Cheers,

Hugh

Ruslan Kabalin (rkabalin) wrote :

Hello Hugh, Thanks a lot for your patch. I am just thinking, why not using divs with "display:inline-block" css setting for displaying members so that the number of rows will be adjusted automatically? This fixed number might be prone to errors for non-standard scale (see attached image, I have produced it after applying your patch).

Hugh Davenport (hugh-davenport) wrote :

Hi Ruslan,

Are you able to give me more details on how you produced this error?

How many columns?

How wide is your window screen?

What browser?

Cheers,

Hugh

Hugh Davenport (hugh-davenport) wrote :

Ignore that last one, found completely missed the setting for "Larger right column" which produces this.

Hugh Davenport (hugh-davenport) wrote :

I have updated the patch at
https://reviews.mahara.org/111

It now uses divs as you wanted. An extra style change had to be made so it looked similar to original.

The div's have been set at a width of 64px, 60 for the max size image, and 2 for border. This makes the member name
wrap as it used to.

Cheers,

Hugh

Changed in mahara:
status: In Progress → Fix Committed
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Duplicates of this bug

Other bug subscribers