artefact/file/blocktype/internalmedia/lib.php adds additional & breaking some media players

[Andrew Nicols]

Seen on the Support forum: http://mahara.org/interaction/forum/topic.php?id=2225
The internalmedia player seems to be unable to play some videos on some OSs because of an & in the URL.

I think that I may be responsible for this one - bug #548308 gives more detail. This was originally added as a potential solution to a problem with exporting views. However, the download_link is apparently also used for displaying the video inline and teh additional & causes some issues as a result.

[Brett Wilkins (brettwilkins)]

I can't find any use for this function outside of the player link/embed calls, so making this change (as shown in the forum link) shouldn't be an issue, and should result in the players working again.

[Richard Mansfield (richard-mansfield)]

Right, but I guess if we change & back to & we'll have to reopen bug #548308, won't we?
(Not that I mind, broken videos in html exports is better than broken vids on the site)

[Richard Mansfield (richard-mansfield)]

Have changed this back from & to & (reverted e7f95427) and fixed bug #548308 in a different way.