friend request issues (with two similar accounts)
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Mahara |
Invalid
|
Low
|
Unassigned |
Bug Description
Charlie and I had a bit of trouble with friend requests on master.dev.
Here's the timeline of the events:
1. Charlie sends friend request to Kristina (member of Mahoodle).
2. Kristina accepts friend request and leaves browser window (FF 3.6 on Mac 10.6) open (and sends a wall message to Charlie as well)
3. Charlie sends friend request to Kristina DC (admin on master.dev)
4. real Kristina clicks on link in email and sees the friend request in Mahara BUT while still logged in as Kristina (and not Kristina DC). It says "1 pending friend" there despite it being the request for Kristina DC
5. Kristina tries to approve friend request but gets error message: "Mahara: Master Branch: Site unavailable. A nonrecoverable error occured. This probably means you have encountered a bug in the system."
6. Kristina tries to deny friend request and succeeds.
7. Charlie receives friend denial from Kristina, but is still friends with Kristina on master.dev as that was the denial for the friend request for Kristina DC
8. real Kristina logs into Mahara as Kristina DC and sees friend request from Charlie
9. Kristina DC can accept friend request without problems
Changed in mahara: | |
assignee: | nobody → Andrew Robert Nicols (dobedobedoh) |
Changed in mahara: | |
status: | Triaged → Confirmed |
Changed in mahara: | |
status: | Confirmed → Incomplete |
Changed in mahara: | |
status: | Incomplete → Invalid |
I had a look at the log -- it looks like the error occurred when trying to accept a friend request from a user you were already friends with. We should detect this case and maybe just reload the page, or do something less ugly than the site unavailable message.