Merging open/invite/request group types

[Kristina Hoeppner]

Just realized that I cannot invite other members to an open group (master.dev). When I create a group and want to invite a bunch of people from the start, it would be nice to have the possibility to invite multiple people like in an invite-only group.

Or did you not provide the multiple invite option to avoid spammers creating groups and signing everybody up?

[François Marier (fmarier)]

I suppose spammers could already create invite-only groups and do the same thing...

[Kristina Hoeppner (kris-hoeppner)]

Actually, I would like to extend this feature wish: An admin should be able to invite multiple people in any group he creates. Even though he may create a request membership group, he could still like to invite a bunch of people from the start. Having to create an "invite only" group and switching it to a "request membership" group after having sent the invitations, seems a bit cumbersome.

[Kristina Hoeppner (kris-hoeppner)]

similar wishlist item at bug 729896

[François Marier (fmarier)]

I agree with Kristina. I don't really see the point of having these groups be of different types.

The invite/request facilities should probably exist for all groups (except the private/controlled ones).

[Kristina Hoeppner (kris-hoeppner)]

Hello Francois,

Thanks for merging these two wishlist items.

> The invite/request facilities should probably exist for all groups (except the private/controlled ones).

Mhh. I think a private group should have the invite functionality (also for multiple invites) but not the request membership functionality as it would not show up in group search results anyway (at least as far as I can remember because it is supposed to be private).

[Kristina Hoeppner (kris-hoeppner)]

Hi Francois,

Actually, re-reading the new wishlist title "Merging open/invite/request group types", I don't fully agree. I would make a distinction between open groups that anybody can join without a rquest being sent to the admin and invite and request groups. I would join the latter two as they need some kind of admin approval and thus are different from an open group.

When merging the groups, the functionality to invite people from their profile pages needs to persist.

[François Marier (fmarier)]

Yeah I suppose what we need is two group types:

1- open: you can join by yourself, no need to place a request. However a group creator can also invite users to join.

2- invite-only: you can't join directly, you need to be invited by the group creator. However, you can place a request to join the group (i.e. you can request an invite).

And then we could have a setting for the invite-only group to turn off the ability for users to request an invite.

[Kristina Hoeppner (kris-hoeppner)]

Sounds good to me. Just a few more specifics:

1. Group type open: Any admin can invite users to join - either via their profile page or in bulk.

2. Any group member should be able to send an invite to others he knows to suggest joining a group. Great would be if they don't have to go to the profile page if they want to invite a number of people, but could select from their list of friends as well (similar to what Facebook does) and thus send multiple invites.

3. Group type invite: Again, any admin can invite people individually or in bulk.

4. Turning off the invite: That would be going into the direction of private groups, right?

5. We still keep the controlled membership groups.

6. Keep in mind the discussion at https://bugs.launchpad.net/mahara/+bug/504830 and http://mahara.org/interaction/forum/topic.php?id=2229

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/625
Committed: http://gitorious.org/mahara/mahara/commit/027ffc0d2414e32be4bf17d78cece9496bde9dcf
Submitter: Richard Mansfield (<email address hidden>)
Branch: master

commit 027ffc0d2414e32be4bf17d78cece9496bde9dcf
Author: Richard Mansfield <email address hidden>
Date: Mon Aug 22 18:27:23 2011 +1200

    Add more flexible group jointypes (bug #610690)

    The four existing jointypes, 'open', 'controlled', 'request' and
    'invite' are mutually exclusive, but they don't need to be so strict.
    This patch introduces more flexibility in the way groups allow new
    members to join.

    * Group admins can always send membership invitations to a group, even
      if it's open or controlled
    * Membership requests can be enabled for any group unless it has open
      membership.
    * The grouptype now determines the set of roles available to a group,
      but no longer restricts the available join types.

    The db upgrade will preserve existing behaviour apart from enabling
    invitations on open, request, and controlled groups.

    Change-Id: I8bb0940a37f3c0c36366c1d5b8d27e8b9914a7e3
    Signed-off-by: Richard Mansfield <email address hidden>

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/643
Committed: http://gitorious.org/mahara/mahara/commit/50db739e25dc1d762f2d9a7ad99ee70dc5640099
Submitter: Francois Marier (<email address hidden>)
Branch: master

commit 50db739e25dc1d762f2d9a7ad99ee70dc5640099
Author: Richard Mansfield <email address hidden>
Date: Tue Sep 6 12:13:52 2011 +1200

    Fix list of invited & requested groups on user profile

    The group jointype changes from bug #610690 (which allow invitations
    to any group) resulted in incorrect lists of invited/requested groups
    on the user profile. Groups the user is already a member of are
    listed under 'invited to join', and controlled groups are listed under
    'requested membership of'. This change fixes these lists, and merges
    the two queries that find the groups for which the logged-in user is an
    admin.

    Change-Id: Iff675790391ef1ada22b6e9bb5930772fd2c3bf3
    Signed-off-by: Richard Mansfield <email address hidden>

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/658
Committed: http://gitorious.org/mahara/mahara/commit/4526d8282f58f73dcce77eb9b63542a043ec37e9
Submitter: Richard Mansfield (<email address hidden>)
Branch: master

commit 4526d8282f58f73dcce77eb9b63542a043ec37e9
Author: Richard Mansfield <email address hidden>
Date: Thu Sep 8 15:22:58 2011 +1200

    Fix string on upload group csv page (bug #610690)

    The csv field name was changed from 'grouptype' to 'roles' in
    commit 027ffc0d24, to better describe what the grouptype field
    does, but wasn't updated in the list of mandatory fields in the
    page description.

    Change-Id: I24408eb2b368abbb653e076b47ba92882832c528
    Signed-off-by: Richard Mansfield <email address hidden>

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/740
Committed: http://gitorious.org/mahara/mahara/commit/84c3b20e3edfa6721fe5f30564350176cd531efd
Submitter: Hugh Davenport (<email address hidden>)
Branch: master

commit 84c3b20e3edfa6721fe5f30564350176cd531efd
Author: Richard Mansfield <email address hidden>
Date: Mon Sep 26 18:01:18 2011 +1300

    Don't show roles dropdown when the user can't change it (bug #610690)

    The grouptype (roles) drop-down is displayed even when the logged in
    user can't create course groups. It should be hidden in this case.

    Change-Id: I91bd037c807ba88cd9a02f1c9852beb22b23ce94
    Signed-off-by: Richard Mansfield <email address hidden>

[Melissa Draper (melissa)]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

status fixreleased
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEcBAEBAgAGBQJPjqdlAAoJECXBtiziiXdcxeoH/iQi1ljFCaDUrA07cq6IAZga
p3Tw7VRtZBy6Cl5NwOFg1b4/DsqFIM9fQPb+WpJqUAcTVP6B44QElOCtb0ldeZCw
cgWlkkSj1jk/gpCdKhCZ2MMHkRjMao5ZpUyF4vSO26tIiYcvPIhRoF6uWu0Z40xe
1wee4ZKGEEvO13bujMyuu4nEQSd9TK5VWPn+PbIKFEyJgCY19Zw62fWBXoanPbWj
LDuO9AnaQOPyVEx2qtoH8M5LFra2zq+dZ9Ac7oAiLffcWJAB9MqL8o2zbQHpOuVi
Ynrh6BIyUYaqdt1BhALrJ6/MQ0h7mDKGy8CVg0z4e2VHyxecYwc84kwzrItH7I0=
=mdeb
-----END PGP SIGNATURE-----

[Melissa Draper (melissa)]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

 status fixreleased
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEcBAEBAgAGBQJPjrRzAAoJECXBtiziiXdcggYH/39bWTAPjHe9fUi3ve11K6iW
/R7j+mSc51e/47Cx0Z1Xv1HkDY0ymFLyRU/4CgErzWLWtrlSVhDx/r3gf8aHj+A+
ICmHRmTTCRBij5sKZVZbzZDN/t9drPvJ1u1dWcagGR2DiXoxAa9Kd2LUXKScRvS6
DqhQWj42JiOoo1R1FGFLa8dpPwlzwuLKyQQ6gvdDutva0E3RqktUUBy8w6ieMG6E
UM/K4sdgx7AAhfBxg91349DOjKeHE/69Vb1gbJXE9UtY/xwe+3sgBtAM7aN4e5US
PhBcGckRLkgxpwLwDzTNGuDHFp51OjIdqXaoRAxXx3tgOonY2bs/eqg42RJBcR4=
=dLjM
-----END PGP SIGNATURE-----