langconfig needs a new command to display names correctly

Bug #597097 reported by Heinz Krettek
20
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Undecided
Richard Mansfield

Bug Description

Hi,

using the german langpack I noticed that the month names are not displayed in German letters.

Example: in groups te joinded date shows 4. may

Penny showed me to insert a line in the langconfig.php file, but it should be handled better.

setlocale (LC_ALL, 'de_DE.utf8');

Revision history for this message
Richard Mansfield (richard-mansfield) wrote :

On master I am moving locales to a string in langconfig.php, because we want to remove all php code out of the language packs. setlocale will be called on every request, the first time the current user language is retrieved. Langpacks for master should therefore define the 'locales' string in langconfig.php (comma-separated list) instead of calling setlocale directly, e.g.

  $string['locales'] = 'en_US.utf8,en_GB.utf8,en';

I've tested this using the German language pack with the de_DE.utf8 locale installed on my server, and

  $string['locales'] = 'de_DE.utf8';

in langconfig.php, and it's showing the German month names correctly. It would be nice to make the locale a user preference, but I think that's overkill for what we need at the moment.

Changed in mahara:
status: New → Fix Committed
milestone: none → 1.3.0
Changed in mahara:
assignee: nobody → Richard Mansfield (richard-mansfield)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.