Displaying folder block subfolder in modal doesn't respect "Sort order of files " option

Bug #1991339 reported by Robert Lyon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Unassigned

Bug Description

We used to update the block's content with the render_instance() function but now that we open it in a modal we only call it by artefact id - so lose the block settings for ordering

we need to open it via the render_details_in_modal() function so we can find/use the sort order setting

Revision history for this message
Robert Lyon (robertl-9) wrote :

To test:

Create a folder in files section and in that folder create some sub folders and in one of those sub folders put some files and make some folders

Add a folders block to a page and pick the parent folder and set the sort order to descending

When you view the page you should see the sub folders listed in the sort order you chose

Click on the sub folder that has content:

You should see it's content appear in modal and be ordered correctly

Changed in mahara:
milestone: none → 22.10.0
importance: Undecided → Medium
status: New → In Progress
Revision history for this message
Robert Lyon (robertl-9) wrote :
Changed in mahara:
milestone: 22.10.0 → 23.04.0
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/c/mahara/+/13186
Committed: https://git.mahara.org/mahara/mahara/commit/40bffedd3068476b71a348acfae6754e17433e82
Submitter: "Robert Lyon <email address hidden>"
Branch: main

commit 40bffedd3068476b71a348acfae6754e17433e82
Author: Robert Lyon <email address hidden>
Date: Fri Sep 30 13:10:16 2022 +1300

Bug 1991339: looking into the issue with folder display in modal

Change-Id: I129d668fd10b6e31ec41c0f76acb6a36de86db10
Signed-off-by: Robert Lyon <email address hidden>

Robert Lyon (robertl-9)
Changed in mahara:
status: In Progress → Fix Committed
Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.