Allow the LTI/LTI_Advantage to process the 'lis_person_sourcedid' as a remoteusername

[Robert Lyon]

When a Moodle connects to Mahara via LTI/LTI advantage it sends the Moodle user_id value that we consume as the remoteusername, which is fine normally.

But if the LTI/LTI advantage auth method has a parent auth method (such as SAML) then the Moodle user_id is not helpful.

What we need is the value of the ID of the Identity Provider for the account in Moodle.

There is the 'lis_person_sourcedid' field that can carry the ID of the IdP login name for Moodle.

In Moodle:
        'user_id' => $USER->id,
        'lis_person_sourcedid' => $USER->idnumber,

So we want to set that value as an auth remoteusername in addition to the user_id

[Robert Lyon (robertl-9)]

https://reviews.mahara.org/c/mahara/+/13161

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/c/mahara/+/13161
Committed: https://git.mahara.org/mahara/mahara/commit/97447a21ffc7165af0f7075c2e49cca8d51447d9
Submitter: "Robert Lyon <email address hidden>"
Branch: main

commit 97447a21ffc7165af0f7075c2e49cca8d51447d9
Author: Robert Lyon <email address hidden>
Date: Tue Sep 13 08:49:49 2022 +1200

Bug 1989388: Allow 'lis_person_sourcedid' to be recorded as a remoteusername

And record it as remoteusername to the parentauth
This is because moodle can send the moodle ID as remoteauth name not
the username from the remote IdP that ties everything together

Also tidy up LTI_Advantage to be like LTI
- See Bug 1943772, commit ec27a6d715c0d015c94e3ec3d0bada974886bbb8

Change-Id: Icbc3bc4511d9cb3b1fb12103f76f5d67539224e3
Signed-off-by: Robert Lyon <email address hidden>

[Mahara Bot (dev-mahara)]

Patch for "22.10_DEV" branch: https://reviews.mahara.org/c/mahara/+/13288

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/c/mahara/+/13288
Committed: https://git.mahara.org/mahara/mahara/commit/72f6dc73d1d55f095c11e59fb4b8879e2eb21f47
Submitter: "Robert Lyon <email address hidden>"
Branch: 22.10_DEV

commit 72f6dc73d1d55f095c11e59fb4b8879e2eb21f47
Author: Robert Lyon <email address hidden>
Date: Tue Sep 13 08:49:49 2022 +1200

Bug 1989388: Allow 'lis_person_sourcedid' to be recorded as a remoteusername

And record it as remoteusername to the parentauth
This is because moodle can send the moodle ID as remoteauth name not
the username from the remote IdP that ties everything together

Also tidy up LTI_Advantage to be like LTI
- See Bug 1943772, commit ec27a6d715c0d015c94e3ec3d0bada974886bbb8

Change-Id: Icbc3bc4511d9cb3b1fb12103f76f5d67539224e3
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 97447a21ffc7165af0f7075c2e49cca8d51447d9)