Mahara

Add nvm support

  1. Series 21.10
  2. Bug #1988096
Bug #1988096 reported by Doris Tam
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
21.10
Fix Released
High
Unassigned
Mahara 21.10.5
22.04
Fix Released
High
Unassigned
Mahara 22.04.3
22.10
Fix Released
High
Doris Tam
Mahara 22.10.0

Bug Description

Related to: https://bugs.launchpad.net/mahara/+bug/1973639

Having nvm will help with Behat testing in Jenkins when different Mahara versions require different node versions. NVM will automatically install and switch to another node version when a .nvmrc file exists. The value in the file given must match a node version.

The Makefile will need an update to support this.

See original description
Doris Tam (doristam)
description: updated
Changed in mahara:
assignee: nobody → Doris Tam (doristam)
milestone: none → 22.10.0
status: New → In Progress
Robert Lyon (robertl-9)
Changed in mahara:
importance: Undecided → Wishlist
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/c/mahara/+/13122
Committed: https://git.mahara.org/mahara/mahara/commit/3fba5d640839a1178863621661e44aef983ca384
Submitter: "Robert Lyon <email address hidden>"
Branch: main

commit 3fba5d640839a1178863621661e44aef983ca384
Author: Doris Tam <email address hidden>
Date: Tue Aug 30 10:09:00 2022 +1200

Bug 1988096: Add nvm support in Makefile + .nvmrc

Note: the version in .nvmrc may need to be updated for older/newer versions of Mahara

Change-Id: I5c273bc8d66768352ff0a112bd09bbee24066b25

Robert Lyon (robertl-9)
Changed in mahara:
status: In Progress → Fix Committed
importance: Wishlist → High
Robert Lyon (robertl-9)
no longer affects: mahara/21.04
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "21.10_DEV" branch: https://reviews.mahara.org/c/mahara/+/13187

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "22.04_DEV" branch: https://reviews.mahara.org/c/mahara/+/13188

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/c/mahara/+/13188
Committed: https://git.mahara.org/mahara/mahara/commit/52f1731a164af175061cd5cc77c27d21dafd49bc
Submitter: "Robert Lyon <email address hidden>"
Branch: 22.04_DEV

commit 52f1731a164af175061cd5cc77c27d21dafd49bc
Author: Doris Tam <email address hidden>
Date: Tue Aug 30 10:09:00 2022 +1200

Bug 1988096: Add nvm support in Makefile + .nvmrc

Note: the version in .nvmrc may need to be updated for older/newer versions of Mahara

Change-Id: I5c273bc8d66768352ff0a112bd09bbee24066b25

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/c/mahara/+/13187
Committed: https://git.mahara.org/mahara/mahara/commit/96217142fdd6c4e1b38f4de8a917315879fa0948
Submitter: "Robert Lyon <email address hidden>"
Branch: 21.10_DEV

commit 96217142fdd6c4e1b38f4de8a917315879fa0948
Author: Doris Tam <email address hidden>
Date: Tue Aug 30 10:09:00 2022 +1200

Bug 1988096: Add nvm support in Makefile + .nvmrc

Note: the version in .nvmrc may need to be updated for older/newer versions of Mahara

Change-Id: I5c273bc8d66768352ff0a112bd09bbee24066b25

Kristina Hoeppner (kris-hoeppner)
no longer affects: mahara
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.