PHP 8 Compatibility: phan

Bug #1984140 reported by Gold
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Wishlist
Gold

Bug Description

We have been using phan as one of the static analysis tools but it is reporting a large number of false negatives.

I'm seeing some old conversation in the issue queue for the project but it looks to have been closed due to inactivity.

Given the lack of active issues on this I'm suspecting that phan is more useful on modern codebases.

With the number of false negatives we should remove phan at this time.

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review
Changed in mahara:
status: New → In Progress
milestone: none → 22.10.0
importance: Undecided → Medium
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/c/mahara/+/13046
Committed: https://git.mahara.org/mahara/mahara/commit/bdda318ce1817f40ca452db2fa1b8f6ea2b5f068
Submitter: "Robert Lyon <email address hidden>"
Branch: main

commit bdda318ce1817f40ca452db2fa1b8f6ea2b5f068
Author: Gold <email address hidden>
Date: Wed Aug 10 10:44:45 2022 +1200

Bug 1984140: PHP 8 Compatibility: phan

Remove phan from composer.json

Change-Id: Ic21eac1fe0be9da58442369dfbe121c5ba8697f5

Robert Lyon (robertl-9)
Changed in mahara:
status: In Progress → Fix Committed
tags: added: newfeature
Changed in mahara:
importance: Medium → Wishlist
Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.