PHP 8 Compatibility: theme

[Gold]

This is to track patchsets that will bring the codebase up to be compliant with PHP 8.1.

The initial run through will be on a top level directory basis. i.e. the directories below htdocs. It will focus on the results from the PHPStan and Phan static analysis tools.

This bug tracks files in the theme directory.

Testing will require identifying, from the patchset, where the code is used and then verifying that that area of the site still works in both PHP 7.4 and PHP 8.1.

https://phpstan.org/
https://github.com/phan/phan

[Mahara Bot (dev-mahara)]

Patch for "main" branch: https://reviews.mahara.org/c/mahara/+/12942

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/c/mahara/+/12942
Committed: https://git.mahara.org/mahara/mahara/commit/b5c84b489a3e28c6deaecf15669f0c9f327f3cdb
Submitter: "Robert Lyon <email address hidden>"
Branch: main

commit b5c84b489a3e28c6deaecf15669f0c9f327f3cdb
Author: Gold <email address hidden>
Date: Wed Jun 22 11:51:44 2022 +1200

Bug 1976430: PHP 8 Compatibility: theme

Signed-off-by: Gold <email address hidden>
Change-Id: I750ace7d59b22f9f196e8bfb419c42b2c8247a4c

[Mahara Bot (dev-mahara)]

Patch for "main" branch: https://reviews.mahara.org/c/mahara/+/13014

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/c/mahara/+/13014
Committed: https://git.mahara.org/mahara/mahara/commit/1c3088356ee351033d63f2d4df950a3672e744c6
Submitter: "Robert Lyon <email address hidden>"
Branch: main

commit 1c3088356ee351033d63f2d4df950a3672e744c6
Author: Gold <email address hidden>
Date: Fri Jul 29 11:46:19 2022 +1200

Bug 1976430: PHP 8 Compatibility: theme

Moving the element title on the delete buttons so behat can target it.

Change-Id: Iaf2ca43f2dec131c5f4da3a9d48bde552a2a00f3