PHP 8 Compatibility: search

[Gold]

This is to track patchsets that will bring the codebase up to be compliant with PHP 8.1.

The initial run through will be on a top level directory basis. i.e. the directories below htdocs. It will focus on the results from the PHPStan and Phan static analysis tools.

This bug tracks files in the search directory.

Testing will require identifying, from the patchset, where the code is used and then verifying that that area of the site still works in both PHP 7.4 and PHP 8.1.

https://phpstan.org/
https://github.com/phan/phan

[Mahara Bot (dev-mahara)]

Patch for "main" branch: https://reviews.mahara.org/c/mahara/+/12940

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/c/mahara/+/12940
Committed: https://git.mahara.org/mahara/mahara/commit/ad5ca9d1e385e663afb28ad10fd6b8aaaeda59dd
Submitter: "Doris Tam <email address hidden>"
Branch: main

commit ad5ca9d1e385e663afb28ad10fd6b8aaaeda59dd
Author: Gold <email address hidden>
Date: Wed Jun 22 10:47:11 2022 +1200

Bug 1976426: PHP 8 Compatibility: search

Signed-off-by: Gold <email address hidden>
Change-Id: I6befe082eeb044022d0b53025ef11c621696e0bc