PHP 8 Compatibility: json

[Gold]

This is to track patchsets that will bring the codebase up to be compliant with PHP 8.1.

The initial run through will be on a top level directory basis. i.e. the directories below htdocs. It will focus on the results from the PHPStan and Phan static analysis tools.

This bug tracks files in the json directory.

Testing will require identifying, from the patchset, where the code is used and then verifying that that area of the site still works in both PHP 7.4 and PHP 8.1.

https://phpstan.org/
https://github.com/phan/phan

[Mahara Bot (dev-mahara)]

Patch for "main" branch: https://reviews.mahara.org/c/mahara/+/12889

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/c/mahara/+/12889
Committed: https://git.mahara.org/mahara/mahara/commit/0b582e96060325e511b0f2acbb9b0b045f19f038
Submitter: "Robert Lyon <email address hidden>"
Branch: main

commit 0b582e96060325e511b0f2acbb9b0b045f19f038
Author: Gold <email address hidden>
Date: Fri Jun 17 11:56:26 2022 +1200

Bug 1976422: PHP 8 Compatibility: json

Added default values for many vars.
Refactored relatedtagssearch.php to allow $view to be unambiguously
available later in the script.
Corrected the @return in lib/view.php for static analysis.
Removed htdocs/json/search.php as the file that used it was removed
in commit e7619c78c6e828aacd08cbde8b38e6a6da3e5268

Signed-off-by: Gold <email address hidden>
Change-Id: I996372b033e05bfdbe01bffc135383ee0590b13d