PHP 8 Compatibility: import

Bug #1976420 reported by Gold
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Wishlist
Gold

Bug Description

This is to track patchsets that will bring the codebase up to be compliant with PHP 8.1.

The initial run through will be on a top level directory basis. i.e. the directories below htdocs. It will focus on the results from the PHPStan and Phan static analysis tools.

This bug tracks files in the import directory.

Testing will require identifying, from the patchset, where the code is used and then verifying that that area of the site still works in both PHP 7.4 and PHP 8.1.

https://phpstan.org/
https://github.com/phan/phan

Revision history for this message
Gold (gold.catalyst) wrote :

Not sure the review linked. Miss typed the bug number.

https://reviews.mahara.org/c/mahara/+/12862

Gold (gold.catalyst)
Changed in mahara:
status: Confirmed → In Progress
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/c/mahara/+/12862
Committed: https://git.mahara.org/mahara/mahara/commit/c874e0225f5db0875d9bf89f79870d1f27abc31b
Submitter: "Robert Lyon <email address hidden>"
Branch: main

commit c874e0225f5db0875d9bf89f79870d1f27abc31b
Author: Gold <email address hidden>
Date: Wed Jun 8 15:13:01 2022 +1200

Bug 1976420: PHP 8 Compatibility: import

Adjusted the nginx client_max_body_size to be same as apache upload_max_filesize
so that we can test uploading import files over 1MB

Signed-off-by: Gold <email address hidden>
Change-Id: I30e5f40f31a1bb20286f33cab192cfbc1569846e

Robert Lyon (robertl-9)
Changed in mahara:
status: In Progress → Fix Committed
Changed in mahara:
importance: High → Wishlist
tags: added: newfeature
Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.