PHP 8 Compatibility: artefact

[Gold]

This is to track patchsets that will bring the codebase up to be compliant with PHP 8.1.

The initial run through will be on a top level directory basis. i.e. the directories below htdocs. It will focus on the results from the PHPStan and Phan static analysis tools.

This bug tracks files in the artefact directory

Testing will require identifying, from the patchset, where the code is used and then verifying that that area of the site still works in both PHP 7.4 and PHP 8.1.

https://phpstan.org/
https://github.com/phan/phan

[Mahara Bot (dev-mahara)]

Patch for "main" branch: https://reviews.mahara.org/c/mahara/+/12836

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/c/mahara/+/12836
Committed: https://git.mahara.org/mahara/mahara/commit/e603c13ac3b3cc9feb863556fe665533ce739b0e
Submitter: "Robert Lyon <email address hidden>"
Branch: main

commit e603c13ac3b3cc9feb863556fe665533ce739b0e
Author: Gold <email address hidden>
Date: Tue Jun 7 10:50:51 2022 +1200

Bug 1976417: PHP 8 Compatibility: artefact

Minor syntax fixes.
Fixing static calls.

Signed-off-by: Gold <email address hidden>
Change-Id: I7b560d48cb9c33e79944328caebdc38371007bc1