PHP 8 Compatibility: admin

[Gold]

This is to track patchsets that will bring the codebase up to be compliant with PHP 8.1.

The initial run through will be on a top level directory basis. i.e. the directories below htdocs. It will focus on the results from the PHPStan and Phan static analysis tools.

This bug tracks files in the admin directory

Testing will require identifying, from the patchset, where the code is used and then verifying that that area of the site still works in both PHP 7.4 and PHP 8.1.

https://phpstan.org/
https://github.com/phan/phan

[Mahara Bot (dev-mahara)]

Patch for "main" branch: https://reviews.mahara.org/c/mahara/+/12831

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/c/mahara/+/12831
Committed: https://git.mahara.org/mahara/mahara/commit/3139ec6b439ce7125a930d086ad8bdf0be03d762
Submitter: "Robert Lyon <email address hidden>"
Branch: main

commit 3139ec6b439ce7125a930d086ad8bdf0be03d762
Author: Gold <email address hidden>
Date: Wed Jun 1 10:53:25 2022 +1200

Bug 1976414: PHP8 Compatibility: admin

Removed a var from a couple of fetch_etag() calls. It was a global var.

Added a default value for smarty $headingclass

Change-Id: I24840ee69d52f9906d19c771d834e73c21c9ef17

[Mahara Bot (dev-mahara)]

Patch for "main" branch: https://reviews.mahara.org/c/mahara/+/13550

[Mahara Bot (dev-mahara)]

Patch for "main" branch: https://reviews.mahara.org/c/mahara/+/13556

[Mahara Bot (dev-mahara)]

Patch for "main" branch: https://reviews.mahara.org/c/mahara/+/13558

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/c/mahara/+/13550
Committed: https://git.mahara.org/mahara/mahara/commit/82042df215b2cb2eccc3487d718dec2e9979dc5b
Submitter: "Robert Lyon <email address hidden>"
Branch: main

commit 82042df215b2cb2eccc3487d718dec2e9979dc5b
Author: Gold <email address hidden>
Date: Wed Dec 14 15:51:41 2022 +1300

Bug 1976414: PHP8 Compatibility: Reserved word 'PUBLIC'

Function name, class name, namespace name or constant name can not
be reserved keyword 'PUBLIC' (since version 5.0)

Signed-off-by: Gold <email address hidden>
Change-Id: I97ac2bf3d0bd61028ba6518d87315eb817c632cd

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/c/mahara/+/13556
Committed: https://git.mahara.org/mahara/mahara/commit/32df1382083714b6c7b829a64f7d7d7a41e591ef
Submitter: "Robert Lyon <email address hidden>"
Branch: main

commit 32df1382083714b6c7b829a64f7d7d7a41e591ef
Author: Gold <email address hidden>
Date: Fri Dec 16 14:14:14 2022 +1300

Bug 1976414: PHP8 Compatibility: Deprecated INI Directives

Signed-off-by: Gold <email address hidden>
Change-Id: I044a50dd43bfa13f0e11bca109958fc339fa1247

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/c/mahara/+/13558
Committed: https://git.mahara.org/mahara/mahara/commit/8cb083352c887d1d4f63a2817384610c9504874e
Submitter: "Robert Lyon <email address hidden>"
Branch: main

commit 8cb083352c887d1d4f63a2817384610c9504874e
Author: Gold <email address hidden>
Date: Mon Dec 19 09:25:22 2022 +1300

Bug 1976414: PHP8 Compatibility: curly braces to remove ambiguity

Indirect access to variables, properties and methods will be evaluated strictly
in left-to-right order since PHP 7.0. Use curly braces to remove ambiguity.

Signed-off-by: Gold <email address hidden>
Change-Id: I68bac2dd3711e222da0c8a003c25dbab9986f883

[Mahara Bot (dev-mahara)]

Patch for "main" branch: https://reviews.mahara.org/c/mahara/+/13622

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/c/mahara/+/13622
Committed: https://git.mahara.org/mahara/mahara/commit/d4b979cac6127b0b28955fe0fd50f2a204501703
Submitter: "Robert Lyon <email address hidden>"
Branch: main

commit d4b979cac6127b0b28955fe0fd50f2a204501703
Author: Gold <email address hidden>
Date: Fri Jan 20 08:16:36 2023 +1300

Bug 1976414: PHP8 Compatibility: Reserved word 'PUBLIC'

A few new ones have been added from other work.

Signed-off-by: Gold <email address hidden>
Change-Id: I19417f73e2cdb6e9e1a07f3962eba2c8e5f2198c