PHP 8 Compatibility: Blocktype

[Gold]

This is to track patchsets that will bring the codebase up to be compliant with PHP 8.1.

The initial run through will be on a top level directory basis. i.e. the directories below htdocs. It will focus on the results from the PHPStan and Phan static analysis tools.

This bug tracks files in the blocktype directory.

Testing will require identifying, from the patchset, where the code is used and then verifying that that area of the site still works in both PHP 7.4 and PHP 8.1.

https://phpstan.org/
https://github.com/phan/phan

[Gold (gold.catalyst)]

Current review:
https://reviews.mahara.org/c/mahara/+/12829

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/c/mahara/+/12829
Committed: https://git.mahara.org/mahara/mahara/commit/c3d93da46af8a0078ca554f1897e2e6e69a519aa
Submitter: "Robert Lyon <email address hidden>"
Branch: main

commit c3d93da46af8a0078ca554f1897e2e6e69a519aa
Author: Gold <email address hidden>
Date: Tue May 31 09:03:15 2022 +1200

Bug 1976411: PHP8 Compatibility: Blocktype

Added htdocs/lib/htmlpurifier/HTMLPurifier/Exception.php to phpstan.neon
so the HTMLPurifier_Exception class could be found. No issues in lib.php
for PHPStan now.

Updated docblock for db_format_timestamp() to accurately reflect the
parameter and what is being returned. PHPStan no longer complains about
this in htdocs/blocktype/watchlist/lib.php

Moved MAXFRIENDDISPLAY into the PluginBlocktypeMyfriends class and
updated references. PHPStan finds this now.

Change-Id: I91dc154c5e94dedb82b6af9ae7dbca9a144b76c5