Mahara

Plans js error - Uncaught ReferenceError: findButtonDataUrls is not defined

  1. Series 22.10
  2. Bug #1975753
Bug #1975753 reported by Robert Lyon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
21.10
Fix Released
High
Unassigned
Mahara 21.10.5
22.04
Fix Released
High
Unassigned
Mahara 22.04.3
22.10
Fix Released
High
Robert Lyon
Mahara 22.10.0

Bug Description

We include the javascript for Plans before the mahara.js file where the findButtonDataUrls() is defined.

We need to include mahara.js before the plugins js

Robert Lyon (robertl-9)
Changed in mahara:
status: New → In Progress
Revision history for this message
Robert Lyon (robertl-9) wrote :

It looks like it causes problem with paginator.js too so we need to move mahara.js to above that one

no longer affects: mahara/21.04
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "main" branch: https://reviews.mahara.org/c/mahara/+/12886

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/c/mahara/+/12886
Committed: https://git.mahara.org/mahara/mahara/commit/e56698bc0548ebf97101b78c227dea6a04adc11c
Submitter: "Doris Tam <email address hidden>"
Branch: main

commit e56698bc0548ebf97101b78c227dea6a04adc11c
Author: Robert Lyon <email address hidden>
Date: Thu May 26 11:20:05 2022 +1200

Bug 1975753: Include mahara.js before plugins

In case they rely on a function in mahara.js

Change-Id: I5e30e01de5fd4e4de7a4f2d87f662e907ff7c651
Signed-off-by: Robert Lyon <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "22.04_DEV" branch: https://reviews.mahara.org/c/mahara/+/13034

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "21.10_DEV" branch: https://reviews.mahara.org/c/mahara/+/13035

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/c/mahara/+/13034
Committed: https://git.mahara.org/mahara/mahara/commit/392b08e42c43dc7f98020623c4c6464065d823ca
Submitter: "Doris Tam <email address hidden>"
Branch: 22.04_DEV

commit 392b08e42c43dc7f98020623c4c6464065d823ca
Author: Robert Lyon <email address hidden>
Date: Thu May 26 11:20:05 2022 +1200

Bug 1975753: Include mahara.js before plugins

In case they rely on a function in mahara.js

Change-Id: I5e30e01de5fd4e4de7a4f2d87f662e907ff7c651
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit e56698bc0548ebf97101b78c227dea6a04adc11c)

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/c/mahara/+/13035
Committed: https://git.mahara.org/mahara/mahara/commit/37e6e18e78d1ade0463d88084c740e71991560ae
Submitter: "Doris Tam <email address hidden>"
Branch: 21.10_DEV

commit 37e6e18e78d1ade0463d88084c740e71991560ae
Author: Robert Lyon <email address hidden>
Date: Thu May 26 11:20:05 2022 +1200

Bug 1975753: Include mahara.js before plugins

In case they rely on a function in mahara.js

Change-Id: I5e30e01de5fd4e4de7a4f2d87f662e907ff7c651
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit e56698bc0548ebf97101b78c227dea6a04adc11c)

Kristina Hoeppner (kris-hoeppner)
no longer affects: mahara
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.